mirror of
https://github.com/nodejs/node.git
synced 2025-04-29 14:25:18 +00:00
21b0a27af8
This reverts commit 9359de9dd2.
Original Commit Message:
The "fs" module has two functions called `maybeCallback` and
`makeCallback`, as of now.
The `maybeCallback` creates a default function to report errors, if the
parameter passed is not a function object. Basically, if the callback
is omitted in some cases, this function is used to create a default
callback function.
The `makeCallback`, OTOH, creates a default function only if the
parameter passed is `undefined`, and if it is not a function object it
will throw an `Error`.
This patch removes the `maybeCallback` function and makes the callback
function argument mandatory for all the async functions.
PR-URL: https://github.com/nodejs/node/pull/7168
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/7846
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
35 lines
1.0 KiB
JavaScript
35 lines
1.0 KiB
JavaScript
'use strict';
|
|
var common = require('../common');
|
|
var assert = require('assert');
|
|
var exec = require('child_process').exec;
|
|
var path = require('path');
|
|
|
|
// `fs.readFile('/')` does not fail on FreeBSD, because you can open and read
|
|
// the directory there.
|
|
if (process.platform === 'freebsd') {
|
|
common.skip('platform not supported.');
|
|
return;
|
|
}
|
|
|
|
function test(env, cb) {
|
|
var filename = path.join(common.fixturesDir, 'test-fs-readfile-error.js');
|
|
var execPath = '"' + process.execPath + '" "' + filename + '"';
|
|
var options = { env: Object.assign(process.env, env) };
|
|
exec(execPath, options, function(err, stdout, stderr) {
|
|
assert(err);
|
|
assert.equal(stdout, '');
|
|
assert.notEqual(stderr, '');
|
|
cb('' + stderr);
|
|
});
|
|
}
|
|
|
|
test({ NODE_DEBUG: '' }, common.mustCall(function(data) {
|
|
assert(/EISDIR/.test(data));
|
|
assert(!/test-fs-readfile-error/.test(data));
|
|
}));
|
|
|
|
test({ NODE_DEBUG: 'fs' }, common.mustCall(function(data) {
|
|
assert(/EISDIR/.test(data));
|
|
assert(/test-fs-readfile-error/.test(data));
|
|
}));
|