mirror of
https://github.com/nodejs/node.git
synced 2025-05-02 13:11:36 +00:00
21b0a27af8
This reverts commit 9359de9dd2.
Original Commit Message:
The "fs" module has two functions called `maybeCallback` and
`makeCallback`, as of now.
The `maybeCallback` creates a default function to report errors, if the
parameter passed is not a function object. Basically, if the callback
is omitted in some cases, this function is used to create a default
callback function.
The `makeCallback`, OTOH, creates a default function only if the
parameter passed is `undefined`, and if it is not a function object it
will throw an `Error`.
This patch removes the `maybeCallback` function and makes the callback
function argument mandatory for all the async functions.
PR-URL: https://github.com/nodejs/node/pull/7168
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/7846
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
37 lines
1.2 KiB
JavaScript
37 lines
1.2 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const fs = require('fs');
|
|
const path = require('path');
|
|
const Buffer = require('buffer').Buffer;
|
|
|
|
common.refreshTmpDir();
|
|
|
|
const tmpFolder = fs.mkdtempSync(path.join(common.tmpDir, 'foo.'));
|
|
|
|
assert(path.basename(tmpFolder).length === 'foo.XXXXXX'.length);
|
|
assert(common.fileExists(tmpFolder));
|
|
|
|
const utf8 = fs.mkdtempSync(path.join(common.tmpDir, '\u0222abc.'));
|
|
assert.equal(Buffer.byteLength(path.basename(utf8)),
|
|
Buffer.byteLength('\u0222abc.XXXXXX'));
|
|
assert(common.fileExists(utf8));
|
|
|
|
function handler(err, folder) {
|
|
assert.ifError(err);
|
|
assert(common.fileExists(folder));
|
|
assert.strictEqual(this, null);
|
|
}
|
|
|
|
fs.mkdtemp(path.join(common.tmpDir, 'bar.'), common.mustCall(handler));
|
|
|
|
// Same test as above, but making sure that passing an options object doesn't
|
|
// affect the way the callback function is handled.
|
|
fs.mkdtemp(path.join(common.tmpDir, 'bar.'), {}, common.mustCall(handler));
|
|
|
|
// Making sure that not passing a callback doesn't crash, as a default function
|
|
// is passed internally.
|
|
assert.doesNotThrow(() => fs.mkdtemp(path.join(common.tmpDir, 'bar-')));
|
|
assert.doesNotThrow(() => fs.mkdtemp(path.join(common.tmpDir, 'bar-'), {}));
|