node/tools/eslint-rules/lowercase-name-for-primitive.js
cjihrig 203ce5f9e0
tools: simplify lowercase-name-for-primitive rule
PR-URL: https://github.com/nodejs/node/pull/17653
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
2017-12-15 11:19:01 -05:00

47 lines
1.2 KiB
JavaScript

/**
* @fileoverview Check that TypeError[ERR_INVALID_ARG_TYPE] uses
* lowercase for primitive types
* @author Weijia Wang <starkwang@126.com>
*/
'use strict';
//------------------------------------------------------------------------------
// Rule Definition
//------------------------------------------------------------------------------
const astSelector = 'NewExpression[callee.property.name="TypeError"]' +
'[arguments.0.value="ERR_INVALID_ARG_TYPE"]';
const primitives = [
'number', 'string', 'boolean', 'null', 'undefined'
];
module.exports = function(context) {
function checkNamesArgument(node) {
const names = node.arguments[2];
switch (names.type) {
case 'Literal':
checkName(node, names.value);
break;
case 'ArrayExpression':
names.elements.forEach((name) => {
checkName(node, name.value);
});
break;
}
}
function checkName(node, name) {
const lowercaseName = name.toLowerCase();
if (primitives.includes(lowercaseName) && !primitives.includes(name)) {
const msg = `primitive should use lowercase: ${name}`;
context.report(node, msg);
}
}
return {
[astSelector]: (node) => checkNamesArgument(node)
};
};