mirror of
https://github.com/nodejs/node.git
synced 2025-05-08 14:36:08 +00:00
1f94b85069
The internal `assert` modules `errorCache` property is exposed only for testing. The one test that used it is rewritten here to not use it. This has the following advantages: * The test now makes sure that there is an empty cache in a more robust way. Instead of relying on the internal implementation of `errorCache`, it simply spawns a separate process. * One less test using the `--expose-internals` flag. PR-URL: https://github.com/nodejs/node/pull/23304 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
49 lines
1.4 KiB
JavaScript
49 lines
1.4 KiB
JavaScript
'use strict';
|
|
|
|
// Do not read filesystem when creating AssertionError messages for code in
|
|
// builtin modules.
|
|
|
|
require('../common');
|
|
const assert = require('assert');
|
|
const EventEmitter = require('events');
|
|
const e = new EventEmitter();
|
|
e.on('hello', assert);
|
|
|
|
if (process.argv[2] !== 'child') {
|
|
const tmpdir = require('../common/tmpdir');
|
|
tmpdir.refresh();
|
|
const { spawnSync } = require('child_process');
|
|
|
|
let threw = false;
|
|
try {
|
|
e.emit('hello', false);
|
|
} catch (err) {
|
|
const frames = err.stack.split('\n');
|
|
const [, filename, , ] = frames[1].match(/\((.+):(\d+):(\d+)\)/);
|
|
// Spawn a child process to avoid the error having been cached in the assert
|
|
// module's `errorCache` Map.
|
|
|
|
const { output, status, error } =
|
|
spawnSync(process.execPath,
|
|
[process.argv[1], 'child', filename],
|
|
{ cwd: tmpdir.path, env: process.env });
|
|
assert.ifError(error);
|
|
assert.strictEqual(status, 0, `Exit code: ${status}\n${output}`);
|
|
threw = true;
|
|
}
|
|
assert.ok(threw);
|
|
} else {
|
|
const { writeFileSync } = require('fs');
|
|
const [, , , filename, line, column] = process.argv;
|
|
const data = `${'\n'.repeat(line - 1)}${' '.repeat(column - 1)}` +
|
|
'ok(failed(badly));';
|
|
|
|
writeFileSync(filename, data);
|
|
assert.throws(
|
|
() => e.emit('hello', false),
|
|
{
|
|
message: 'false == true'
|
|
}
|
|
);
|
|
}
|