mirror of
https://github.com/nodejs/node.git
synced 2025-05-09 09:08:46 +00:00

This updates all Node.js errors by removing the `code` being part of the `name` property. Instead, the name is just changed once on instantiation, the stack is accessed to create the stack as expected and then the `name` property is set back to it's original form. PR-URL: https://github.com/nodejs/node/pull/26738 Fixes: https://github.com/nodejs/node/issues/26669 Fixes: https://github.com/nodejs/node/issues/20253 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
327 lines
8.7 KiB
JavaScript
327 lines
8.7 KiB
JavaScript
// Copyright Joyent, Inc. and other Node contributors.
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a
|
|
// copy of this software and associated documentation files (the
|
|
// "Software"), to deal in the Software without restriction, including
|
|
// without limitation the rights to use, copy, modify, merge, publish,
|
|
// distribute, sublicense, and/or sell copies of the Software, and to permit
|
|
// persons to whom the Software is furnished to do so, subject to the
|
|
// following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included
|
|
// in all copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
|
|
// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
|
|
// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN
|
|
// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
|
|
// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
|
|
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
|
|
// USE OR OTHER DEALINGS IN THE SOFTWARE.
|
|
|
|
'use strict';
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
|
|
const dns = require('dns');
|
|
const dnsPromises = dns.promises;
|
|
|
|
const existing = dns.getServers();
|
|
assert(existing.length > 0);
|
|
|
|
// Verify that setServers() handles arrays with holes and other oddities
|
|
{
|
|
const servers = [];
|
|
|
|
servers[0] = '127.0.0.1';
|
|
servers[2] = '0.0.0.0';
|
|
dns.setServers(servers);
|
|
|
|
assert.deepStrictEqual(dns.getServers(), ['127.0.0.1', '0.0.0.0']);
|
|
}
|
|
|
|
{
|
|
const servers = ['127.0.0.1', '192.168.1.1'];
|
|
|
|
servers[3] = '127.1.0.1';
|
|
servers[4] = '127.1.0.1';
|
|
servers[5] = '127.1.1.1';
|
|
|
|
Object.defineProperty(servers, 2, {
|
|
enumerable: true,
|
|
get: () => {
|
|
servers.length = 3;
|
|
return '0.0.0.0';
|
|
}
|
|
});
|
|
|
|
dns.setServers(servers);
|
|
assert.deepStrictEqual(dns.getServers(), [
|
|
'127.0.0.1',
|
|
'192.168.1.1',
|
|
'0.0.0.0'
|
|
]);
|
|
}
|
|
|
|
{
|
|
// Various invalidities, all of which should throw a clean error.
|
|
const invalidServers = [
|
|
' ',
|
|
'\n',
|
|
'\0',
|
|
'1'.repeat(3 * 4),
|
|
// Check for REDOS issues.
|
|
':'.repeat(100000),
|
|
'['.repeat(100000),
|
|
'['.repeat(100000) + ']'.repeat(100000) + 'a'
|
|
];
|
|
invalidServers.forEach((serv) => {
|
|
assert.throws(
|
|
() => {
|
|
dns.setServers([serv]);
|
|
},
|
|
{
|
|
name: 'TypeError',
|
|
code: 'ERR_INVALID_IP_ADDRESS'
|
|
}
|
|
);
|
|
});
|
|
}
|
|
|
|
const goog = [
|
|
'8.8.8.8',
|
|
'8.8.4.4',
|
|
];
|
|
dns.setServers(goog);
|
|
assert.deepStrictEqual(dns.getServers(), goog);
|
|
common.expectsError(() => dns.setServers(['foobar']), {
|
|
code: 'ERR_INVALID_IP_ADDRESS',
|
|
type: TypeError,
|
|
message: 'Invalid IP address: foobar'
|
|
});
|
|
common.expectsError(() => dns.setServers(['127.0.0.1:va']), {
|
|
code: 'ERR_INVALID_IP_ADDRESS',
|
|
type: TypeError,
|
|
message: 'Invalid IP address: 127.0.0.1:va'
|
|
});
|
|
assert.deepStrictEqual(dns.getServers(), goog);
|
|
|
|
const goog6 = [
|
|
'2001:4860:4860::8888',
|
|
'2001:4860:4860::8844',
|
|
];
|
|
dns.setServers(goog6);
|
|
assert.deepStrictEqual(dns.getServers(), goog6);
|
|
|
|
goog6.push('4.4.4.4');
|
|
dns.setServers(goog6);
|
|
assert.deepStrictEqual(dns.getServers(), goog6);
|
|
|
|
const ports = [
|
|
'4.4.4.4:53',
|
|
'[2001:4860:4860::8888]:53',
|
|
'103.238.225.181:666',
|
|
'[fe80::483a:5aff:fee6:1f04]:666'
|
|
];
|
|
const portsExpected = [
|
|
'4.4.4.4',
|
|
'2001:4860:4860::8888',
|
|
'103.238.225.181:666',
|
|
'[fe80::483a:5aff:fee6:1f04]:666'
|
|
];
|
|
dns.setServers(ports);
|
|
assert.deepStrictEqual(dns.getServers(), portsExpected);
|
|
|
|
dns.setServers([]);
|
|
assert.deepStrictEqual(dns.getServers(), []);
|
|
|
|
{
|
|
const errObj = {
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
type: TypeError,
|
|
message: 'The "rrtype" argument must be of type string. ' +
|
|
'Received type object'
|
|
};
|
|
common.expectsError(() => {
|
|
dns.resolve('example.com', [], common.mustNotCall());
|
|
}, errObj);
|
|
common.expectsError(() => {
|
|
dnsPromises.resolve('example.com', []);
|
|
}, errObj);
|
|
}
|
|
{
|
|
const errObj = {
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
type: TypeError,
|
|
message: 'The "name" argument must be of type string. ' +
|
|
'Received type undefined'
|
|
};
|
|
common.expectsError(() => {
|
|
dnsPromises.resolve();
|
|
}, errObj);
|
|
}
|
|
|
|
// dns.lookup should accept only falsey and string values
|
|
{
|
|
const errorReg = common.expectsError({
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
type: TypeError,
|
|
message: /^The "hostname" argument must be of type string\. Received type .*/
|
|
}, 10);
|
|
|
|
assert.throws(() => dns.lookup({}, common.mustNotCall()), errorReg);
|
|
|
|
assert.throws(() => dns.lookup([], common.mustNotCall()), errorReg);
|
|
|
|
assert.throws(() => dns.lookup(true, common.mustNotCall()), errorReg);
|
|
|
|
assert.throws(() => dns.lookup(1, common.mustNotCall()), errorReg);
|
|
|
|
assert.throws(() => dns.lookup(common.mustNotCall(), common.mustNotCall()),
|
|
errorReg);
|
|
|
|
assert.throws(() => dnsPromises.lookup({}), errorReg);
|
|
assert.throws(() => dnsPromises.lookup([]), errorReg);
|
|
assert.throws(() => dnsPromises.lookup(true), errorReg);
|
|
assert.throws(() => dnsPromises.lookup(1), errorReg);
|
|
assert.throws(() => dnsPromises.lookup(common.mustNotCall()), errorReg);
|
|
}
|
|
|
|
// dns.lookup should accept falsey values
|
|
{
|
|
const checkCallback = (err, address, family) => {
|
|
assert.ifError(err);
|
|
assert.strictEqual(address, null);
|
|
assert.strictEqual(family, 4);
|
|
};
|
|
|
|
['', null, undefined, 0, NaN].forEach(async (value) => {
|
|
const res = await dnsPromises.lookup(value);
|
|
assert.deepStrictEqual(res, { address: null, family: 4 });
|
|
dns.lookup(value, common.mustCall(checkCallback));
|
|
});
|
|
}
|
|
|
|
{
|
|
/*
|
|
* Make sure that dns.lookup throws if hints does not represent a valid flag.
|
|
* (dns.V4MAPPED | dns.ADDRCONFIG) + 1 is invalid because:
|
|
* - it's different from dns.V4MAPPED and dns.ADDRCONFIG.
|
|
* - it's different from them bitwise ored.
|
|
* - it's different from 0.
|
|
* - it's an odd number different than 1, and thus is invalid, because
|
|
* flags are either === 1 or even.
|
|
*/
|
|
const hints = (dns.V4MAPPED | dns.ADDRCONFIG) + 1;
|
|
const err = {
|
|
code: 'ERR_INVALID_OPT_VALUE',
|
|
type: TypeError,
|
|
message: /The value "\d+" is invalid for option "hints"/
|
|
};
|
|
|
|
common.expectsError(() => {
|
|
dnsPromises.lookup('nodejs.org', { hints });
|
|
}, err);
|
|
common.expectsError(() => {
|
|
dns.lookup('nodejs.org', { hints }, common.mustNotCall());
|
|
}, err);
|
|
}
|
|
|
|
common.expectsError(() => dns.lookup('nodejs.org'), {
|
|
code: 'ERR_INVALID_CALLBACK',
|
|
type: TypeError
|
|
});
|
|
|
|
common.expectsError(() => dns.lookup('nodejs.org', 4), {
|
|
code: 'ERR_INVALID_CALLBACK',
|
|
type: TypeError
|
|
});
|
|
|
|
dns.lookup('', { family: 4, hints: 0 }, common.mustCall());
|
|
|
|
dns.lookup('', {
|
|
family: 6,
|
|
hints: dns.ADDRCONFIG
|
|
}, common.mustCall());
|
|
|
|
dns.lookup('', { hints: dns.V4MAPPED }, common.mustCall());
|
|
|
|
dns.lookup('', {
|
|
hints: dns.ADDRCONFIG | dns.V4MAPPED
|
|
}, common.mustCall());
|
|
|
|
(async function() {
|
|
await dnsPromises.lookup('', { family: 4, hints: 0 });
|
|
await dnsPromises.lookup('', { family: 6, hints: dns.ADDRCONFIG });
|
|
await dnsPromises.lookup('', { hints: dns.V4MAPPED });
|
|
await dnsPromises.lookup('', { hints: dns.ADDRCONFIG | dns.V4MAPPED });
|
|
})();
|
|
|
|
{
|
|
const err = {
|
|
code: 'ERR_MISSING_ARGS',
|
|
type: TypeError,
|
|
message: 'The "hostname", "port", and "callback" arguments must be ' +
|
|
'specified'
|
|
};
|
|
|
|
common.expectsError(() => dns.lookupService('0.0.0.0'), err);
|
|
err.message = 'The "hostname" and "port" arguments must be specified';
|
|
common.expectsError(() => dnsPromises.lookupService('0.0.0.0'), err);
|
|
}
|
|
|
|
{
|
|
const invalidHost = 'fasdfdsaf';
|
|
const err = {
|
|
code: 'ERR_INVALID_OPT_VALUE',
|
|
type: TypeError,
|
|
message: `The value "${invalidHost}" is invalid for option "hostname"`
|
|
};
|
|
|
|
common.expectsError(() => {
|
|
dnsPromises.lookupService(invalidHost, 0);
|
|
}, err);
|
|
|
|
common.expectsError(() => {
|
|
dns.lookupService(invalidHost, 0, common.mustNotCall());
|
|
}, err);
|
|
}
|
|
|
|
const portErr = (port) => {
|
|
const err = {
|
|
code: 'ERR_SOCKET_BAD_PORT',
|
|
message:
|
|
`Port should be >= 0 and < 65536. Received ${port}.`,
|
|
type: RangeError
|
|
};
|
|
|
|
common.expectsError(() => {
|
|
dnsPromises.lookupService('0.0.0.0', port);
|
|
}, err);
|
|
|
|
common.expectsError(() => {
|
|
dns.lookupService('0.0.0.0', port, common.mustNotCall());
|
|
}, err);
|
|
};
|
|
portErr(null);
|
|
portErr(undefined);
|
|
portErr(65538);
|
|
portErr('test');
|
|
|
|
common.expectsError(() => {
|
|
dns.lookupService('0.0.0.0', 80, null);
|
|
}, {
|
|
code: 'ERR_INVALID_CALLBACK',
|
|
type: TypeError
|
|
});
|
|
|
|
{
|
|
dns.resolveMx('foo.onion', function(err) {
|
|
assert.deepStrictEqual(err.errno, 'ENOTFOUND');
|
|
assert.deepStrictEqual(err.code, 'ENOTFOUND');
|
|
assert.deepStrictEqual(err.syscall, 'queryMx');
|
|
assert.deepStrictEqual(err.hostname, 'foo.onion');
|
|
assert.deepStrictEqual(err.message, 'queryMx ENOTFOUND foo.onion');
|
|
});
|
|
}
|