mirror of
https://github.com/nodejs/node.git
synced 2025-05-04 13:07:46 +00:00
1ec09b0449
If JS throws an object whose toString() method throws, then Node attempts to print an empty message, but actually prints garbage. This commit checks for this case, and prints a message instead. Fixes: https://github.com/nodejs/node/issues/4079 PR-URL: https://github.com/nodejs/node/pull/4112 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
73 lines
1.8 KiB
JavaScript
73 lines
1.8 KiB
JavaScript
'use strict';
|
|
var common = require('../common');
|
|
var assert = require('assert');
|
|
var exec = require('child_process').exec;
|
|
var path = require('path');
|
|
|
|
var exits = 0;
|
|
|
|
function errExec(script, callback) {
|
|
var cmd = '"' + process.argv[0] + '" "' +
|
|
path.join(common.fixturesDir, script) + '"';
|
|
return exec(cmd, function(err, stdout, stderr) {
|
|
// There was some error
|
|
assert.ok(err);
|
|
|
|
// More than one line of error output.
|
|
assert.ok(stderr.split('\n').length > 2);
|
|
|
|
// Assert the script is mentioned in error output.
|
|
assert.ok(stderr.indexOf(script) >= 0);
|
|
|
|
// Proxy the args for more tests.
|
|
callback(err, stdout, stderr);
|
|
|
|
// Count the tests
|
|
exits++;
|
|
});
|
|
}
|
|
|
|
|
|
// Simple throw error
|
|
errExec('throws_error.js', function(err, stdout, stderr) {
|
|
assert.ok(/blah/.test(stderr));
|
|
});
|
|
|
|
|
|
// Trying to JSON.parse(undefined)
|
|
errExec('throws_error2.js', function(err, stdout, stderr) {
|
|
assert.ok(/SyntaxError/.test(stderr));
|
|
});
|
|
|
|
|
|
// Trying to JSON.parse(undefined) in nextTick
|
|
errExec('throws_error3.js', function(err, stdout, stderr) {
|
|
assert.ok(/SyntaxError/.test(stderr));
|
|
});
|
|
|
|
|
|
// throw ILLEGAL error
|
|
errExec('throws_error4.js', function(err, stdout, stderr) {
|
|
assert.ok(/\/\*\*/.test(stderr));
|
|
assert.ok(/SyntaxError/.test(stderr));
|
|
});
|
|
|
|
// Specific long exception line doesn't result in stack overflow
|
|
errExec('throws_error5.js', function(err, stdout, stderr) {
|
|
assert.ok(/SyntaxError/.test(stderr));
|
|
});
|
|
|
|
// Long exception line with length > errorBuffer doesn't result in assertion
|
|
errExec('throws_error6.js', function(err, stdout, stderr) {
|
|
assert.ok(/SyntaxError/.test(stderr));
|
|
});
|
|
|
|
// Object that throws in toString() doesn't print garbage
|
|
errExec('throws_error7.js', function(err, stdout, stderr) {
|
|
assert.ok(/<toString\(\) threw exception/.test(stderr));
|
|
});
|
|
|
|
process.on('exit', function() {
|
|
assert.equal(7, exits);
|
|
});
|