mirror of
https://github.com/nodejs/node.git
synced 2025-05-21 08:27:49 +00:00
1c29da8236
* Throw ERR_TLS_SNI_FROM_SERVER when setting server names on a server-side socket instead of returning silently * Assert on wrap_->started and wrap_->ssl instead of throwing errors since these errors indicate that the user either uses private APIs, or monkey-patches internals, or hits a bug. PR-URL: https://github.com/nodejs/node/pull/18125 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
47 lines
1.1 KiB
JavaScript
47 lines
1.1 KiB
JavaScript
'use strict';
|
|
|
|
// This tests the errors thrown from TLSSocket.prototype.setServername
|
|
|
|
const common = require('../common');
|
|
const fixtures = require('../common/fixtures');
|
|
|
|
if (!common.hasCrypto)
|
|
common.skip('missing crypto');
|
|
|
|
const { connect, TLSSocket } = require('tls');
|
|
const makeDuplexPair = require('../common/duplexpair');
|
|
const { clientSide, serverSide } = makeDuplexPair();
|
|
|
|
const key = fixtures.readKey('agent1-key.pem');
|
|
const cert = fixtures.readKey('agent1-cert.pem');
|
|
const ca = fixtures.readKey('ca1-cert.pem');
|
|
|
|
const client = connect({
|
|
socket: clientSide,
|
|
ca,
|
|
host: 'agent1' // Hostname from certificate
|
|
});
|
|
|
|
[undefined, null, 1, true, {}].forEach((value) => {
|
|
common.expectsError(() => {
|
|
client.setServername(value);
|
|
}, {
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
message: 'The "name" argument must be of type string'
|
|
});
|
|
});
|
|
|
|
const server = new TLSSocket(serverSide, {
|
|
isServer: true,
|
|
key,
|
|
cert,
|
|
ca
|
|
});
|
|
|
|
common.expectsError(() => {
|
|
server.setServername('localhost');
|
|
}, {
|
|
code: 'ERR_TLS_SNI_FROM_SERVER',
|
|
message: 'Cannot issue SNI from a TLS server-side socket'
|
|
});
|