mirror of
https://github.com/nodejs/node.git
synced 2025-05-09 07:27:32 +00:00
1b719fe3d7
When building --without-ssl and running the tests some of the http2 test
fail with the following error message:
internal/util.js:82
throw new errors.Error('ERR_NO_CRYPTO');
^
Error [ERR_NO_CRYPTO]: Node.js is not compiled with OpenSSL crypto
support
at Object.assertCrypto (internal/util.js:82:11)
at internal/http2/core.js:5:26
at NativeModule.compile (bootstrap_node.js:586:7)
at NativeModule.require (bootstrap_node.js:531:18)
at http2.js:17:5
at NativeModule.compile (bootstrap_node.js:586:7)
at Function.NativeModule.require (bootstrap_node.js:531:18)
at Function.Module._load (module.js:449:25)
at Module.require (module.js:517:17)
at require (internal/module.js:11:18)
This commit adds hasCrypto checks and skips the tests if there is no
crypto support.
PR-URL: https://github.com/nodejs/node/pull/14657
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
97 lines
2.7 KiB
JavaScript
97 lines
2.7 KiB
JavaScript
// Flags: --expose-http2
|
|
'use strict';
|
|
|
|
// Tests the ability to minimally request a byte range with respondWithFD
|
|
|
|
const common = require('../common');
|
|
if (!common.hasCrypto)
|
|
common.skip('missing crypto');
|
|
const http2 = require('http2');
|
|
const assert = require('assert');
|
|
const path = require('path');
|
|
const fs = require('fs');
|
|
|
|
const {
|
|
HTTP2_HEADER_CONTENT_TYPE,
|
|
HTTP2_HEADER_CONTENT_LENGTH
|
|
} = http2.constants;
|
|
|
|
const fname = path.resolve(common.fixturesDir, 'printA.js');
|
|
const data = fs.readFileSync(fname);
|
|
const fd = fs.openSync(fname, 'r');
|
|
|
|
// Note: this is not anywhere close to a proper implementation of the range
|
|
// header.
|
|
function getOffsetLength(range) {
|
|
if (range === undefined)
|
|
return [0, -1];
|
|
const r = /bytes=(\d+)-(\d+)/.exec(range);
|
|
return [+r[1], +r[2] - +r[1]];
|
|
}
|
|
|
|
const server = http2.createServer();
|
|
server.on('stream', (stream, headers) => {
|
|
|
|
const [ offset, length ] = getOffsetLength(headers.range);
|
|
|
|
stream.respondWithFD(fd, {
|
|
[HTTP2_HEADER_CONTENT_TYPE]: 'text/plain'
|
|
}, {
|
|
statCheck: common.mustCall((stat, headers, options) => {
|
|
assert.strictEqual(options.length, length);
|
|
assert.strictEqual(options.offset, offset);
|
|
headers[HTTP2_HEADER_CONTENT_LENGTH] =
|
|
Math.min(options.length, stat.size - offset);
|
|
}),
|
|
offset: offset,
|
|
length: length
|
|
});
|
|
});
|
|
server.on('close', common.mustCall(() => fs.closeSync(fd)));
|
|
server.listen(0, () => {
|
|
const client = http2.connect(`http://localhost:${server.address().port}`);
|
|
|
|
let remaining = 2;
|
|
function maybeClose() {
|
|
if (--remaining === 0) {
|
|
client.destroy();
|
|
server.close();
|
|
}
|
|
}
|
|
|
|
{
|
|
const req = client.request({ range: 'bytes=8-11' });
|
|
|
|
req.on('response', common.mustCall((headers) => {
|
|
assert.strictEqual(headers[HTTP2_HEADER_CONTENT_TYPE], 'text/plain');
|
|
assert.strictEqual(+headers[HTTP2_HEADER_CONTENT_LENGTH], 3);
|
|
}));
|
|
req.setEncoding('utf8');
|
|
let check = '';
|
|
req.on('data', (chunk) => check += chunk);
|
|
req.on('end', common.mustCall(() => {
|
|
assert.strictEqual(check, data.toString('utf8', 8, 11));
|
|
}));
|
|
req.on('streamClosed', common.mustCall(maybeClose));
|
|
req.end();
|
|
}
|
|
|
|
{
|
|
const req = client.request({ range: 'bytes=8-28' });
|
|
|
|
req.on('response', common.mustCall((headers) => {
|
|
assert.strictEqual(headers[HTTP2_HEADER_CONTENT_TYPE], 'text/plain');
|
|
assert.strictEqual(+headers[HTTP2_HEADER_CONTENT_LENGTH], 9);
|
|
}));
|
|
req.setEncoding('utf8');
|
|
let check = '';
|
|
req.on('data', (chunk) => check += chunk);
|
|
req.on('end', common.mustCall(() => {
|
|
assert.strictEqual(check, data.toString('utf8', 8, 28));
|
|
}));
|
|
req.on('streamClosed', common.mustCall(maybeClose));
|
|
req.end();
|
|
}
|
|
|
|
});
|