mirror of
https://github.com/nodejs/node.git
synced 2025-04-29 14:25:18 +00:00

Calling .end() a second time should be a noop and not leave the socket corked. Fixes: https://github.com/nodejs/node/issues/36620 PR-URL: https://github.com/nodejs/node/pull/36633 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
39 lines
1.0 KiB
JavaScript
39 lines
1.0 KiB
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const http = require('http');
|
|
|
|
const onWriteAfterEndError = common.mustCall((err) => {
|
|
assert.strictEqual(err.code, 'ERR_STREAM_WRITE_AFTER_END');
|
|
}, 2);
|
|
|
|
const server = http.createServer(common.mustCall(function(req, res) {
|
|
res.end('testing ended state', common.mustCall());
|
|
assert.strictEqual(res.writableCorked, 0);
|
|
res.end(common.mustCall((err) => {
|
|
assert.strictEqual(err.code, 'ERR_STREAM_ALREADY_FINISHED');
|
|
}));
|
|
assert.strictEqual(res.writableCorked, 0);
|
|
res.end('end', onWriteAfterEndError);
|
|
assert.strictEqual(res.writableCorked, 0);
|
|
res.on('error', onWriteAfterEndError);
|
|
res.on('finish', common.mustCall(() => {
|
|
res.end(common.mustCall((err) => {
|
|
assert.strictEqual(err.code, 'ERR_STREAM_ALREADY_FINISHED');
|
|
server.close();
|
|
}));
|
|
}));
|
|
}));
|
|
|
|
server.listen(0);
|
|
|
|
server.on('listening', common.mustCall(function() {
|
|
http
|
|
.request({
|
|
port: server.address().port,
|
|
method: 'GET',
|
|
path: '/'
|
|
})
|
|
.end();
|
|
}));
|