mirror of
https://github.com/nodejs/node.git
synced 2025-05-09 19:38:23 +00:00
1ae184a85c
This commit validates the fd parameters to fs.fchmod{Sync} as
int32s instead of uint32s because they are ints in the binding
layer.
PR-URL: https://github.com/nodejs/node/pull/20588
Fixes: https://github.com/nodejs/node/issues/20498
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
84 lines
2.7 KiB
JavaScript
84 lines
2.7 KiB
JavaScript
'use strict';
|
|
require('../common');
|
|
const assert = require('assert');
|
|
const util = require('util');
|
|
const fs = require('fs');
|
|
|
|
// This test ensures that input for fchmod is valid, testing for valid
|
|
// inputs for fd and mode
|
|
|
|
// Check input type
|
|
[false, null, undefined, {}, [], ''].forEach((input) => {
|
|
const errObj = {
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
name: 'TypeError [ERR_INVALID_ARG_TYPE]',
|
|
message: 'The "fd" argument must be of type number. Received type ' +
|
|
typeof input
|
|
};
|
|
assert.throws(() => fs.fchmod(input), errObj);
|
|
assert.throws(() => fs.fchmodSync(input), errObj);
|
|
});
|
|
|
|
|
|
[false, null, undefined, {}, [], '', '123x'].forEach((input) => {
|
|
const errObj = {
|
|
code: 'ERR_INVALID_ARG_VALUE',
|
|
name: 'TypeError [ERR_INVALID_ARG_VALUE]',
|
|
message: 'The argument \'mode\' must be a 32-bit unsigned integer or an ' +
|
|
`octal string. Received ${util.inspect(input)}`
|
|
};
|
|
assert.throws(() => fs.fchmod(1, input), errObj);
|
|
assert.throws(() => fs.fchmodSync(1, input), errObj);
|
|
});
|
|
|
|
[-1, 2 ** 32].forEach((input) => {
|
|
const errObj = {
|
|
code: 'ERR_OUT_OF_RANGE',
|
|
name: 'RangeError [ERR_OUT_OF_RANGE]',
|
|
message: 'The value of "fd" is out of range. It must be >= 0 && <= ' +
|
|
`2147483647. Received ${input}`
|
|
};
|
|
assert.throws(() => fs.fchmod(input), errObj);
|
|
assert.throws(() => fs.fchmodSync(input), errObj);
|
|
});
|
|
|
|
[-1, 2 ** 32].forEach((input) => {
|
|
const errObj = {
|
|
code: 'ERR_OUT_OF_RANGE',
|
|
name: 'RangeError [ERR_OUT_OF_RANGE]',
|
|
message: 'The value of "mode" is out of range. It must be >= 0 && < ' +
|
|
`4294967296. Received ${input}`
|
|
};
|
|
|
|
assert.throws(() => fs.fchmod(1, input), errObj);
|
|
assert.throws(() => fs.fchmodSync(1, input), errObj);
|
|
});
|
|
|
|
[NaN, Infinity].forEach((input) => {
|
|
const errObj = {
|
|
code: 'ERR_OUT_OF_RANGE',
|
|
name: 'RangeError [ERR_OUT_OF_RANGE]',
|
|
message: 'The value of "fd" is out of range. It must be an integer. ' +
|
|
`Received ${input}`
|
|
};
|
|
assert.throws(() => fs.fchmod(input), errObj);
|
|
assert.throws(() => fs.fchmodSync(input), errObj);
|
|
errObj.message = errObj.message.replace('fd', 'mode');
|
|
assert.throws(() => fs.fchmod(1, input), errObj);
|
|
assert.throws(() => fs.fchmodSync(1, input), errObj);
|
|
});
|
|
|
|
[1.5].forEach((input) => {
|
|
const errObj = {
|
|
code: 'ERR_OUT_OF_RANGE',
|
|
name: 'RangeError [ERR_OUT_OF_RANGE]',
|
|
message: 'The value of "fd" is out of range. It must be an integer. ' +
|
|
`Received ${input}`
|
|
};
|
|
assert.throws(() => fs.fchmod(input), errObj);
|
|
assert.throws(() => fs.fchmodSync(input), errObj);
|
|
errObj.message = errObj.message.replace('fd', 'mode');
|
|
assert.throws(() => fs.fchmod(1, input), errObj);
|
|
assert.throws(() => fs.fchmodSync(1, input), errObj);
|
|
});
|