mirror of
https://github.com/nodejs/node.git
synced 2025-05-07 23:52:40 +00:00
8876ac5c35
Fix some issues introduced/not fixed via https://github.com/nodejs/node/pull/25094: * Init hook is not emitted for a reused HTTPParser * HTTPParser was still used as resource in init hook * type used in init hook was always HTTPINCOMINGMESSAGE even for client requests * some tests have not been adapted to new resource names With this change the async hooks init event is emitted during a call to Initialize() as the type and resource object is available at this time. As a result Initialize() must be called now which could be seen as breaking change even HTTPParser is not part of documented API. It was needed to put the ClientRequest instance into a wrapper object instead passing it directly as async resource otherwise test-domain-multi fails. I think this is because adding an EventEmitter to a Domain adds a property 'domain' and the presence of this changes the context propagation in domains. Besides that tests still refering to resource HTTPParser have been updated/improved. Fixes: https://github.com/nodejs/node/issues/27467 Fixes: https://github.com/nodejs/node/issues/26961 Refs: https://github.com/nodejs/node/pull/25094 PR-URL: https://github.com/nodejs/node/pull/27477 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
66 lines
1.6 KiB
JavaScript
66 lines
1.6 KiB
JavaScript
// This test is designed to fail with a segmentation fault in Node.js 4.1.0 and
|
|
// execute without issues in Node.js 4.1.1 and up.
|
|
|
|
// Flags: --expose-internals
|
|
'use strict';
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const httpCommon = require('_http_common');
|
|
const { HTTPParser } = require('_http_common');
|
|
const net = require('net');
|
|
|
|
const COUNT = httpCommon.parsers.max + 1;
|
|
|
|
const parsers = new Array(COUNT);
|
|
for (let i = 0; i < parsers.length; i++)
|
|
parsers[i] = httpCommon.parsers.alloc();
|
|
|
|
let gotRequests = 0;
|
|
let gotResponses = 0;
|
|
|
|
function execAndClose() {
|
|
if (parsers.length === 0)
|
|
return;
|
|
process.stdout.write('.');
|
|
|
|
const parser = parsers.pop();
|
|
parser.initialize(HTTPParser.RESPONSE, {});
|
|
|
|
const socket = net.connect(common.PORT);
|
|
socket.on('error', (e) => {
|
|
// If SmartOS and ECONNREFUSED, then retry. See
|
|
// https://github.com/nodejs/node/issues/2663.
|
|
if (common.isSunOS && e.code === 'ECONNREFUSED') {
|
|
parsers.push(parser);
|
|
parser.reused = true;
|
|
socket.destroy();
|
|
setImmediate(execAndClose);
|
|
return;
|
|
}
|
|
throw e;
|
|
});
|
|
|
|
parser.consume(socket._handle);
|
|
|
|
parser.onIncoming = function onIncoming() {
|
|
process.stdout.write('+');
|
|
gotResponses++;
|
|
parser.unconsume();
|
|
httpCommon.freeParser(parser);
|
|
socket.destroy();
|
|
setImmediate(execAndClose);
|
|
};
|
|
}
|
|
|
|
const server = net.createServer(function(c) {
|
|
if (++gotRequests === COUNT)
|
|
server.close();
|
|
c.end('HTTP/1.1 200 OK\r\n\r\n', function() {
|
|
c.destroySoon();
|
|
});
|
|
}).listen(common.PORT, execAndClose);
|
|
|
|
process.on('exit', function() {
|
|
assert.strictEqual(gotResponses, COUNT);
|
|
});
|