mirror of
https://github.com/nodejs/node.git
synced 2025-05-07 15:35:41 +00:00
da886d9a4c
- Use assert to check mode in the Zlib constructor since it should only be passed by us. - Introduce checkRangesOrGetDefault() and checkFiniteNumber() to simplify type and range checking for numeric arguments - Instead of `ERR_INVALID_OPT_VALUE`, throw `ERR_OUT_OF_RANGE` and `ERR_INVALID_ARG_TYPE` with descriptions of the expected ranges or types to make the errors more user-friendly. - Add message tests for the changed errors PR-URL: https://github.com/nodejs/node/pull/18675 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
47 lines
1.1 KiB
JavaScript
47 lines
1.1 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
|
|
const assert = require('assert');
|
|
const zlib = require('zlib');
|
|
|
|
common.expectsError(
|
|
() => zlib.createGzip({ chunkSize: 0 }),
|
|
{
|
|
code: 'ERR_OUT_OF_RANGE',
|
|
type: RangeError,
|
|
message: 'The value of "options.chunkSize" is out of range. It must ' +
|
|
'be >= 64. Received 0'
|
|
}
|
|
);
|
|
|
|
common.expectsError(
|
|
() => zlib.createGzip({ windowBits: 0 }),
|
|
{
|
|
code: 'ERR_OUT_OF_RANGE',
|
|
type: RangeError,
|
|
message: 'The value of "options.windowBits" is out of range. It must ' +
|
|
'be >= 8 and <= 15. Received 0'
|
|
}
|
|
);
|
|
|
|
common.expectsError(
|
|
() => zlib.createGzip({ memLevel: 0 }),
|
|
{
|
|
code: 'ERR_OUT_OF_RANGE',
|
|
type: RangeError,
|
|
message: 'The value of "options.memLevel" is out of range. It must ' +
|
|
'be >= 1 and <= 9. Received 0'
|
|
}
|
|
);
|
|
|
|
{
|
|
const stream = zlib.createGzip({ level: NaN });
|
|
assert.strictEqual(stream._level, zlib.constants.Z_DEFAULT_COMPRESSION);
|
|
}
|
|
|
|
{
|
|
const stream = zlib.createGzip({ strategy: NaN });
|
|
assert.strictEqual(stream._strategy, zlib.constants.Z_DEFAULT_STRATEGY);
|
|
}
|