mirror of
https://github.com/nodejs/node.git
synced 2025-05-07 13:47:16 +00:00
9fbf0c60b5
Instead of sharing the OS-backed store for all `process.env` instances, create a copy of `process.env` for every worker that is created. The copies do not interact. Native-addons do not see modifications to `process.env` from Worker threads, but child processes started from Workers do default to the Worker’s copy of `process.env`. This makes Workers behave like child processes as far as `process.env` is concerned, and an option corresponding to the `child_process` module’s `env` option is added to the constructor. Fixes: https://github.com/nodejs/node/issues/24947 PR-URL: https://github.com/nodejs/node/pull/26544 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
55 lines
2.0 KiB
JavaScript
55 lines
2.0 KiB
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
const child_process = require('child_process');
|
|
const assert = require('assert');
|
|
const { Worker, workerData } = require('worker_threads');
|
|
|
|
// Test for https://github.com/nodejs/node/issues/24947.
|
|
|
|
if (!workerData && process.argv[2] !== 'child') {
|
|
process.env.SET_IN_PARENT = 'set';
|
|
assert.strictEqual(process.env.SET_IN_PARENT, 'set');
|
|
|
|
new Worker(__filename, { workerData: 'runInWorker' })
|
|
.on('exit', common.mustCall(() => {
|
|
// Env vars from the child thread are not set globally.
|
|
assert.strictEqual(process.env.SET_IN_WORKER, undefined);
|
|
}));
|
|
|
|
process.env.SET_IN_PARENT_AFTER_CREATION = 'set';
|
|
|
|
new Worker(__filename, {
|
|
workerData: 'resetEnv',
|
|
env: { 'MANUALLY_SET': true }
|
|
});
|
|
|
|
common.expectsError(() => {
|
|
new Worker(__filename, { env: 42 });
|
|
}, {
|
|
type: TypeError,
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
message: 'The "options.env" property must be one of type object, ' +
|
|
'undefined, null, or worker_threads.SHARE_ENV. Received type number'
|
|
});
|
|
} else if (workerData === 'runInWorker') {
|
|
// Env vars from the parent thread are inherited.
|
|
assert.strictEqual(process.env.SET_IN_PARENT, 'set');
|
|
assert.strictEqual(process.env.SET_IN_PARENT_AFTER_CREATION, undefined);
|
|
process.env.SET_IN_WORKER = 'set';
|
|
assert.strictEqual(process.env.SET_IN_WORKER, 'set');
|
|
|
|
Object.defineProperty(process.env, 'DEFINED_IN_WORKER', { value: 42 });
|
|
assert.strictEqual(process.env.DEFINED_IN_WORKER, '42');
|
|
|
|
const { stderr } =
|
|
child_process.spawnSync(process.execPath, [__filename, 'child']);
|
|
assert.strictEqual(stderr.toString(), '', stderr.toString());
|
|
} else if (workerData === 'resetEnv') {
|
|
assert.deepStrictEqual(Object.keys(process.env), ['MANUALLY_SET']);
|
|
assert.strictEqual(process.env.MANUALLY_SET, 'true');
|
|
} else {
|
|
// Child processes inherit the parent's env, even from Workers.
|
|
assert.strictEqual(process.env.SET_IN_PARENT, 'set');
|
|
assert.strictEqual(process.env.SET_IN_WORKER, 'set');
|
|
}
|