mirror of
https://github.com/nodejs/node.git
synced 2025-05-07 13:23:28 +00:00
63d4cae009
Having an experimental feature behind a flag makes change if we are expecting significant breaking changes to its API. Since the Worker API has been essentially stable since its initial introduction, and no noticeable doubt about possibly not keeping the feature around has been voiced, removing the flag and thereby reducing the barrier to experimentation, and consequently receiving feedback on the implementation, seems like a good idea. PR-URL: https://github.com/nodejs/node/pull/25361 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Masashi Hirano <shisama07@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
26 lines
1.2 KiB
JavaScript
26 lines
1.2 KiB
JavaScript
// When MessagePort.onmessage is set to a value that is not a function, the
|
|
// setter should call .unref() and .stop(), clearing a previous onmessage
|
|
// listener from holding the event loop open. This test confirms that
|
|
// functionality.
|
|
|
|
'use strict';
|
|
const common = require('../common');
|
|
const { Worker, parentPort } = require('worker_threads');
|
|
|
|
// Do not use isMainThread so that this test itself can be run inside a Worker.
|
|
if (!process.env.HAS_STARTED_WORKER) {
|
|
process.env.HAS_STARTED_WORKER = 1;
|
|
const w = new Worker(__filename);
|
|
w.postMessage(2);
|
|
} else {
|
|
// .onmessage uses a setter. Set .onmessage to a function that ultimately
|
|
// should not be called. This will call .ref() and .start() which will keep
|
|
// the event loop open (and prevent this from exiting) if the subsequent
|
|
// assignment of a value to .onmessage doesn't call .unref() and .stop().
|
|
parentPort.onmessage = common.mustNotCall();
|
|
// Setting `onmessage` to a value that is not a function should clear the
|
|
// previous value and also should allow the event loop to exit. (In other
|
|
// words, this test should exit rather than run indefinitely.)
|
|
parentPort.onmessage = 'fhqwhgads';
|
|
}
|