mirror of
https://github.com/nodejs/node.git
synced 2025-05-07 15:35:41 +00:00
9858e331e3
This patch: - Creates a new test suite `wpt` that can be used to run a subset of Web Platform Tests - Adds a `WPTRunner` in `test/common/wpt.js` that can run the WPT subset in `test/fixtures/wpt` with a vm and the WPT harness while taking the status file in `test/wpt/status` into account. Here we use a new format of status file (in JSON) to handle specific requirements (like ICU requirements) in the tests and to handle expected failures and TODOs. - Adds documentation on how the runner and the update automation works - Runs the WHATWG URL tests and the console tests with the new test runner. With this patch we eliminates the need of copy-pasting with manual modifications to update a large chunk of our WPT subset previously maintained in `test/parallel`. Now the tests run in `test/wpt` can be automatically updated with `git node wpt` without modifications by the actual WPT harness instead of our home-grown mock. There are still a few URL tests left that need to be migrated in the upstream to be placed in .js instead of .html - we currently still use the legacy harness mock in the test files. PR-URL: https://github.com/nodejs/node/pull/24035 Refs: https://github.com/nodejs/node/issues/23192 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
81 lines
2.6 KiB
JavaScript
81 lines
2.6 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
if (!common.hasIntl) {
|
|
// A handful of the tests fail when ICU is not included.
|
|
common.skip('missing Intl');
|
|
}
|
|
|
|
const URL = require('url').URL;
|
|
const { test, assert_equals } = require('../common/wpt').harness;
|
|
const fixtures = require('../common/fixtures');
|
|
|
|
const request = {
|
|
response: require(fixtures.path(
|
|
'wpt', 'url', 'resources', 'setters_tests.json'
|
|
))
|
|
};
|
|
|
|
/* The following tests are copied from WPT. Modifications to them should be
|
|
upstreamed first. Refs:
|
|
https://github.com/w3c/web-platform-tests/blob/8791bed/url/url-setters.html
|
|
License: http://www.w3.org/Consortium/Legal/2008/04-testsuite-copyright.html
|
|
*/
|
|
/* eslint-disable */
|
|
function startURLSettersTests() {
|
|
// var setup = async_test("Loading data…")
|
|
// setup.step(function() {
|
|
// var request = new XMLHttpRequest()
|
|
// request.open("GET", "setters_tests.json")
|
|
// request.send()
|
|
// request.responseType = "json"
|
|
// request.onload = setup.step_func(function() {
|
|
runURLSettersTests(request.response)
|
|
// setup.done()
|
|
// })
|
|
// })
|
|
}
|
|
|
|
function runURLSettersTests(all_test_cases) {
|
|
for (var attribute_to_be_set in all_test_cases) {
|
|
if (attribute_to_be_set == "comment") {
|
|
continue;
|
|
}
|
|
var test_cases = all_test_cases[attribute_to_be_set];
|
|
for(var i = 0, l = test_cases.length; i < l; i++) {
|
|
var test_case = test_cases[i];
|
|
var name = `Setting <${test_case.href}>.${attribute_to_be_set}` +
|
|
` = '${test_case.new_value}'`;
|
|
if ("comment" in test_case) {
|
|
name += ` ${test_case.comment}`;
|
|
}
|
|
test(function() {
|
|
var url = new URL(test_case.href);
|
|
url[attribute_to_be_set] = test_case.new_value;
|
|
for (var attribute in test_case.expected) {
|
|
assert_equals(url[attribute], test_case.expected[attribute])
|
|
}
|
|
}, `URL: ${name}`);
|
|
// test(function() {
|
|
// var url = document.createElement("a");
|
|
// url.href = test_case.href;
|
|
// url[attribute_to_be_set] = test_case.new_value;
|
|
// for (var attribute in test_case.expected) {
|
|
// assert_equals(url[attribute], test_case.expected[attribute])
|
|
// }
|
|
// }, "<a>: " + name)
|
|
// test(function() {
|
|
// var url = document.createElement("area");
|
|
// url.href = test_case.href;
|
|
// url[attribute_to_be_set] = test_case.new_value;
|
|
// for (var attribute in test_case.expected) {
|
|
// assert_equals(url[attribute], test_case.expected[attribute])
|
|
// }
|
|
// }, "<area>: " + name)
|
|
}
|
|
}
|
|
}
|
|
|
|
startURLSettersTests()
|
|
/* eslint-enable */
|