mirror of
https://github.com/nodejs/node.git
synced 2025-05-07 15:35:41 +00:00

This patch: - Creates a new test suite `wpt` that can be used to run a subset of Web Platform Tests - Adds a `WPTRunner` in `test/common/wpt.js` that can run the WPT subset in `test/fixtures/wpt` with a vm and the WPT harness while taking the status file in `test/wpt/status` into account. Here we use a new format of status file (in JSON) to handle specific requirements (like ICU requirements) in the tests and to handle expected failures and TODOs. - Adds documentation on how the runner and the update automation works - Runs the WHATWG URL tests and the console tests with the new test runner. With this patch we eliminates the need of copy-pasting with manual modifications to update a large chunk of our WPT subset previously maintained in `test/parallel`. Now the tests run in `test/wpt` can be automatically updated with `git node wpt` without modifications by the actual WPT harness instead of our home-grown mock. There are still a few URL tests left that need to be migrated in the upstream to be placed in .js instead of .html - we currently still use the legacy harness mock in the test files. PR-URL: https://github.com/nodejs/node/pull/24035 Refs: https://github.com/nodejs/node/issues/23192 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
62 lines
1.9 KiB
JavaScript
62 lines
1.9 KiB
JavaScript
'use strict';
|
|
|
|
// Tests below are not from WPT.
|
|
|
|
const common = require('../common');
|
|
if (!common.hasIntl) {
|
|
// A handful of the tests fail when ICU is not included.
|
|
common.skip('missing Intl');
|
|
}
|
|
|
|
const assert = require('assert');
|
|
const URL = require('url').URL;
|
|
const { test, assert_equals } = require('../common/wpt').harness;
|
|
const fixtures = require('../common/fixtures');
|
|
|
|
// TODO(joyeecheung): we should submit these to the upstream
|
|
const additionalTestCases =
|
|
require(fixtures.path('url-setter-tests-additional.js'));
|
|
|
|
{
|
|
for (const attributeToBeSet in additionalTestCases) {
|
|
if (attributeToBeSet === 'comment') {
|
|
continue;
|
|
}
|
|
const testCases = additionalTestCases[attributeToBeSet];
|
|
for (const testCase of testCases) {
|
|
let name = `Setting <${testCase.href}>.${attributeToBeSet}` +
|
|
` = "${testCase.new_value}"`;
|
|
if ('comment' in testCase) {
|
|
name += ` ${testCase.comment}`;
|
|
}
|
|
test(function() {
|
|
const url = new URL(testCase.href);
|
|
url[attributeToBeSet] = testCase.new_value;
|
|
for (const attribute in testCase.expected) {
|
|
assert_equals(url[attribute], testCase.expected[attribute]);
|
|
}
|
|
}, `URL: ${name}`);
|
|
}
|
|
}
|
|
}
|
|
|
|
{
|
|
const url = new URL('http://example.com/');
|
|
const obj = {
|
|
toString() { throw new Error('toString'); },
|
|
valueOf() { throw new Error('valueOf'); }
|
|
};
|
|
const sym = Symbol();
|
|
const props = Object.getOwnPropertyDescriptors(Object.getPrototypeOf(url));
|
|
for (const [name, { set }] of Object.entries(props)) {
|
|
if (set) {
|
|
assert.throws(() => url[name] = obj,
|
|
/^Error: toString$/,
|
|
`url.${name} = { toString() { throw ... } }`);
|
|
assert.throws(() => url[name] = sym,
|
|
/^TypeError: Cannot convert a Symbol value to a string$/,
|
|
`url.${name} = ${String(sym)}`);
|
|
}
|
|
}
|
|
}
|