mirror of
https://github.com/nodejs/node.git
synced 2025-05-07 12:03:30 +00:00
44d1a46a42
test-url-parse-invalid-input checks the message of an error that is generated by the JavaScript engine. Error messages that change in the underlying JavaScript engine should not be breaking changes in Node.js and therefore should not cause tests to fail. Remove the message check and replace it with a check of the type of the Error object along with the absence of a `code` property. (If a `code` property were present, it would indicate that the error was coming from Node.js rather than the JavaScript engine.) This also makes this test usable without modification in the ChakraCore fork of Node.js. PR-URL: https://github.com/nodejs/node/pull/21132 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
38 lines
1.0 KiB
JavaScript
38 lines
1.0 KiB
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const url = require('url');
|
|
|
|
// https://github.com/joyent/node/issues/568
|
|
[
|
|
[undefined, 'undefined'],
|
|
[null, 'object'],
|
|
[true, 'boolean'],
|
|
[false, 'boolean'],
|
|
[0.0, 'number'],
|
|
[0, 'number'],
|
|
[[], 'object'],
|
|
[{}, 'object'],
|
|
[() => {}, 'function'],
|
|
[Symbol('foo'), 'symbol']
|
|
].forEach(([val, type]) => {
|
|
common.expectsError(() => {
|
|
url.parse(val);
|
|
}, {
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
type: TypeError,
|
|
message: `The "url" argument must be of type string. Received type ${type}`
|
|
});
|
|
});
|
|
|
|
assert.throws(() => { url.parse('http://%E0%A4%A@fail'); },
|
|
(e) => {
|
|
// The error should be a URIError.
|
|
if (!(e instanceof URIError))
|
|
return false;
|
|
|
|
// The error should be from the JS engine and not from Node.js.
|
|
// JS engine errors do not have the `code` property.
|
|
return e.code === undefined;
|
|
});
|