mirror of
https://github.com/nodejs/node.git
synced 2025-05-07 13:47:16 +00:00
0f745bf9bd
OpenSSL 1.0.0 returned incorrect version information. OpenSSL 1.1.0
fixed this, but returning the correct information broke our tests, so
was considered semver-major. Because of this, the version was hard-coded
to the OpenSSL 1.0.0 (incorrect) string in 5fe81c8aff.
This is ancient history, start returning the correct cipher version.
PR-URL: https://github.com/nodejs/node/pull/26625
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
51 lines
1.2 KiB
JavaScript
51 lines
1.2 KiB
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
if (!common.hasCrypto)
|
|
common.skip('missing crypto');
|
|
|
|
const assert = require('assert');
|
|
const tls = require('tls');
|
|
const fixtures = require('../common/fixtures');
|
|
|
|
const options = {
|
|
pfx: [
|
|
{
|
|
buf: fixtures.readKey('agent1.pfx'),
|
|
passphrase: 'sample'
|
|
},
|
|
fixtures.readKey('ec.pfx')
|
|
]
|
|
};
|
|
|
|
const ciphers = [];
|
|
|
|
const server = tls.createServer(options, function(conn) {
|
|
conn.end('ok');
|
|
}).listen(0, function() {
|
|
const ecdsa = tls.connect(this.address().port, {
|
|
ciphers: 'ECDHE-ECDSA-AES256-GCM-SHA384',
|
|
rejectUnauthorized: false
|
|
}, common.mustCall(function() {
|
|
ciphers.push(ecdsa.getCipher());
|
|
const rsa = tls.connect(server.address().port, {
|
|
ciphers: 'ECDHE-RSA-AES256-GCM-SHA384',
|
|
rejectUnauthorized: false
|
|
}, common.mustCall(function() {
|
|
ciphers.push(rsa.getCipher());
|
|
ecdsa.end();
|
|
rsa.end();
|
|
server.close();
|
|
}));
|
|
}));
|
|
});
|
|
|
|
process.on('exit', function() {
|
|
assert.deepStrictEqual(ciphers, [{
|
|
name: 'ECDHE-ECDSA-AES256-GCM-SHA384',
|
|
version: 'TLSv1.2'
|
|
}, {
|
|
name: 'ECDHE-RSA-AES256-GCM-SHA384',
|
|
version: 'TLSv1.2'
|
|
}]);
|
|
});
|