mirror of
https://github.com/nodejs/node.git
synced 2025-05-07 15:35:41 +00:00
707b0a8534
This commit enables ESLint's no-useless-constructor rule. Note that the documentation examples that only include constructor calls were left in tact. PR-URL: https://github.com/nodejs/node/pull/25055 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
58 lines
1.2 KiB
JavaScript
58 lines
1.2 KiB
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
|
|
const stream = require('stream');
|
|
|
|
class MyWritable extends stream.Writable {
|
|
_write(chunk, encoding, callback) {
|
|
assert.notStrictEqual(chunk, null);
|
|
callback();
|
|
}
|
|
}
|
|
|
|
common.expectsError(
|
|
() => {
|
|
const m = new MyWritable({ objectMode: true });
|
|
m.write(null, (err) => assert.ok(err));
|
|
},
|
|
{
|
|
code: 'ERR_STREAM_NULL_VALUES',
|
|
type: TypeError,
|
|
message: 'May not write null values to stream'
|
|
}
|
|
);
|
|
|
|
{ // Should not throw.
|
|
const m = new MyWritable({ objectMode: true }).on('error', assert);
|
|
m.write(null, assert);
|
|
}
|
|
|
|
common.expectsError(
|
|
() => {
|
|
const m = new MyWritable();
|
|
m.write(false, (err) => assert.ok(err));
|
|
},
|
|
{
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
type: TypeError
|
|
}
|
|
);
|
|
|
|
{ // Should not throw.
|
|
const m = new MyWritable().on('error', assert);
|
|
m.write(false, assert);
|
|
}
|
|
|
|
{ // Should not throw.
|
|
const m = new MyWritable({ objectMode: true });
|
|
m.write(false, assert.ifError);
|
|
}
|
|
|
|
{ // Should not throw.
|
|
const m = new MyWritable({ objectMode: true }).on('error', (e) => {
|
|
assert.ifError(e || new Error('should not get here'));
|
|
});
|
|
m.write(false, assert.ifError);
|
|
}
|