mirror of
https://github.com/nodejs/node.git
synced 2025-05-07 13:47:16 +00:00
6f613d8abb
This is work towards resolving the response.finished confusion and future deprecation. Note that implementation-wise, streams have both an ending and ended state. However, in this case (in order to avoid confusion in user space) writableEnded is equal to writable.ending. The ending vs ended situation is internal state required for internal stream logic. PR-URL: https://github.com/nodejs/node/pull/28934 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
26 lines
727 B
JavaScript
26 lines
727 B
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
|
|
const assert = require('assert');
|
|
const stream = require('stream');
|
|
|
|
const writable = new stream.Writable();
|
|
|
|
writable._write = (chunk, encoding, cb) => {
|
|
assert.strictEqual(writable._writableState.ended, false);
|
|
assert.strictEqual(writable.writableEnded, false);
|
|
cb();
|
|
};
|
|
|
|
assert.strictEqual(writable._writableState.ended, false);
|
|
assert.strictEqual(writable.writableEnded, false);
|
|
|
|
writable.end('testing ended state', common.mustCall(() => {
|
|
assert.strictEqual(writable._writableState.ended, true);
|
|
assert.strictEqual(writable.writableEnded, true);
|
|
}));
|
|
|
|
assert.strictEqual(writable._writableState.ended, true);
|
|
assert.strictEqual(writable.writableEnded, true);
|