node/test/parallel/test-stream-transform-final.js
Rishabh Singh 8d15f69abd test: remove third argument from assert.strictEqual()
In file test/parallel/test-stream-transform-final.js the ten calls to
assert.strictEqual() use a string literal as third argument. When
a AssertionError occurs, it reports the string literal and not the
first two arguments, so the third agrument is removed and made a
comment just above the call to assert.strictEqual().

PR-URL: https://github.com/nodejs/node/pull/22051
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
2018-08-02 22:29:53 -04:00

113 lines
2.4 KiB
JavaScript

'use strict';
const common = require('../common');
const assert = require('assert');
const stream = require('stream');
let state = 0;
/*
What you do
var stream = new stream.Transform({
transform: function transformCallback(chunk, _, next) {
// part 1
this.push(chunk);
//part 2
next();
},
final: function endCallback(done) {
// part 1
process.nextTick(function () {
// part 2
done();
});
},
flush: function flushCallback(done) {
// part 1
process.nextTick(function () {
// part 2
done();
});
}
});
t.on('data', dataListener);
t.on('end', endListener);
t.on('finish', finishListener);
t.write(1);
t.write(4);
t.end(7, endMethodCallback);
The order things are called
1. transformCallback part 1
2. dataListener
3. transformCallback part 2
4. transformCallback part 1
5. dataListener
6. transformCallback part 2
7. transformCallback part 1
8. dataListener
9. transformCallback part 2
10. finalCallback part 1
11. finalCallback part 2
12. flushCallback part 1
13. finishListener
14. endMethodCallback
15. flushCallback part 2
16. endListener
*/
const t = new stream.Transform({
objectMode: true,
transform: common.mustCall(function(chunk, _, next) {
// transformCallback part 1
assert.strictEqual(++state, chunk);
this.push(state);
// transformCallback part 2
assert.strictEqual(++state, chunk + 2);
process.nextTick(next);
}, 3),
final: common.mustCall(function(done) {
state++;
// finalCallback part 1
assert.strictEqual(state, 10);
setTimeout(function() {
state++;
// finalCallback part 2
assert.strictEqual(state, 11);
done();
}, 100);
}, 1),
flush: common.mustCall(function(done) {
state++;
// flushCallback part 1
assert.strictEqual(state, 12);
process.nextTick(function() {
state++;
// flushCallback part 2
assert.strictEqual(state, 15);
done();
});
}, 1)
});
t.on('finish', common.mustCall(function() {
state++;
// finishListener
assert.strictEqual(state, 13);
}, 1));
t.on('end', common.mustCall(function() {
state++;
// end event
assert.strictEqual(state, 16);
}, 1));
t.on('data', common.mustCall(function(d) {
// dataListener
assert.strictEqual(++state, d + 1);
}, 3));
t.write(1);
t.write(4);
t.end(7, common.mustCall(function() {
state++;
// endMethodCallback
assert.strictEqual(state, 14);
}, 1));