mirror of
https://github.com/nodejs/node.git
synced 2025-05-07 15:35:41 +00:00

The value of stream.readable and stream.writable should not be used to detect whether a stream is Writable or Readable. Refs: https://github.com/nodejs/node/issues/29395 PR-URL: https://github.com/nodejs/node/pull/29409 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
369 lines
6.8 KiB
JavaScript
369 lines
6.8 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
const { Writable, Readable, Transform, finished } = require('stream');
|
|
const assert = require('assert');
|
|
const EE = require('events');
|
|
const fs = require('fs');
|
|
const { promisify } = require('util');
|
|
|
|
{
|
|
const rs = new Readable({
|
|
read() {}
|
|
});
|
|
|
|
finished(rs, common.mustCall((err) => {
|
|
assert(!err, 'no error');
|
|
}));
|
|
|
|
rs.push(null);
|
|
rs.resume();
|
|
}
|
|
|
|
{
|
|
const ws = new Writable({
|
|
write(data, enc, cb) {
|
|
cb();
|
|
}
|
|
});
|
|
|
|
finished(ws, common.mustCall((err) => {
|
|
assert(!err, 'no error');
|
|
}));
|
|
|
|
ws.end();
|
|
}
|
|
|
|
{
|
|
const tr = new Transform({
|
|
transform(data, enc, cb) {
|
|
cb();
|
|
}
|
|
});
|
|
|
|
let finish = false;
|
|
let ended = false;
|
|
|
|
tr.on('end', () => {
|
|
ended = true;
|
|
});
|
|
|
|
tr.on('finish', () => {
|
|
finish = true;
|
|
});
|
|
|
|
finished(tr, common.mustCall((err) => {
|
|
assert(!err, 'no error');
|
|
assert(finish);
|
|
assert(ended);
|
|
}));
|
|
|
|
tr.end();
|
|
tr.resume();
|
|
}
|
|
|
|
{
|
|
const rs = fs.createReadStream(__filename);
|
|
|
|
rs.resume();
|
|
finished(rs, common.mustCall());
|
|
}
|
|
|
|
{
|
|
const finishedPromise = promisify(finished);
|
|
|
|
async function run() {
|
|
const rs = fs.createReadStream(__filename);
|
|
const done = common.mustCall();
|
|
|
|
let ended = false;
|
|
rs.resume();
|
|
rs.on('end', () => {
|
|
ended = true;
|
|
});
|
|
await finishedPromise(rs);
|
|
assert(ended);
|
|
done();
|
|
}
|
|
|
|
run();
|
|
}
|
|
|
|
{
|
|
const rs = fs.createReadStream('file-does-not-exist');
|
|
|
|
finished(rs, common.expectsError({
|
|
code: 'ENOENT'
|
|
}));
|
|
}
|
|
|
|
{
|
|
const rs = new Readable();
|
|
|
|
finished(rs, common.mustCall((err) => {
|
|
assert(err, 'premature close error');
|
|
}));
|
|
|
|
rs.push(null);
|
|
rs.emit('close');
|
|
rs.resume();
|
|
}
|
|
|
|
{
|
|
const rs = new Readable();
|
|
|
|
finished(rs, common.mustCall((err) => {
|
|
assert(!err, 'no error');
|
|
}));
|
|
|
|
rs.push(null);
|
|
rs.on('end', common.mustCall(() => {
|
|
rs.emit('close'); // Should not trigger an error
|
|
}));
|
|
rs.resume();
|
|
}
|
|
|
|
{
|
|
const rs = new Readable();
|
|
|
|
finished(rs, common.mustCall((err) => {
|
|
assert(err, 'premature close error');
|
|
}));
|
|
|
|
rs.emit('close'); // Should trigger error
|
|
rs.push(null);
|
|
rs.resume();
|
|
}
|
|
|
|
// Test faulty input values and options.
|
|
{
|
|
const rs = new Readable({
|
|
read() {}
|
|
});
|
|
|
|
assert.throws(
|
|
() => finished(rs, 'foo'),
|
|
{
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
message: /callback/
|
|
}
|
|
);
|
|
assert.throws(
|
|
() => finished(rs, 'foo', () => {}),
|
|
{
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
message: /opts/
|
|
}
|
|
);
|
|
assert.throws(
|
|
() => finished(rs, {}, 'foo'),
|
|
{
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
message: /callback/
|
|
}
|
|
);
|
|
|
|
finished(rs, null, common.mustCall());
|
|
|
|
rs.push(null);
|
|
rs.resume();
|
|
}
|
|
|
|
{
|
|
// Nothing happens if disposed.
|
|
|
|
const ws = new Writable({
|
|
write(data, env, cb) {
|
|
cb();
|
|
}
|
|
});
|
|
const removeListener = finished(ws, common.mustNotCall());
|
|
removeListener();
|
|
ws.end();
|
|
}
|
|
|
|
{
|
|
// Nothing happens if disposed.
|
|
|
|
const rs = new Readable();
|
|
const removeListeners = finished(rs, common.mustNotCall());
|
|
removeListeners();
|
|
|
|
rs.emit('close');
|
|
rs.push(null);
|
|
rs.resume();
|
|
}
|
|
|
|
{
|
|
// Completed if readable-like is ended before.
|
|
|
|
const streamLike = new EE();
|
|
streamLike.readableEnded = true;
|
|
streamLike.readable = true;
|
|
finished(streamLike, common.mustCall());
|
|
}
|
|
|
|
{
|
|
// Completed if readable-like is never ended.
|
|
|
|
const streamLike = new EE();
|
|
streamLike.readableEnded = false;
|
|
streamLike.readable = true;
|
|
finished(streamLike, common.expectsError({
|
|
code: 'ERR_STREAM_PREMATURE_CLOSE'
|
|
}));
|
|
streamLike.emit('close');
|
|
}
|
|
|
|
{
|
|
// Completed if writable-like is destroyed before.
|
|
|
|
const streamLike = new EE();
|
|
streamLike.destroyed = true;
|
|
streamLike.writable = true;
|
|
finished(streamLike, common.mustCall());
|
|
}
|
|
|
|
{
|
|
// Completed if readable-like is aborted before.
|
|
|
|
const streamLike = new EE();
|
|
streamLike.destroyed = true;
|
|
streamLike.readable = true;
|
|
finished(streamLike, common.mustCall());
|
|
}
|
|
|
|
{
|
|
// Completed if writable-like is aborted before.
|
|
|
|
const streamLike = new EE();
|
|
streamLike.aborted = true;
|
|
streamLike.writable = true;
|
|
finished(streamLike, common.mustCall());
|
|
}
|
|
|
|
{
|
|
// Completed if readable-like is aborted before.
|
|
|
|
const streamLike = new EE();
|
|
streamLike.aborted = true;
|
|
streamLike.readable = true;
|
|
finished(streamLike, common.mustCall());
|
|
}
|
|
|
|
{
|
|
// Completed if streamlike is finished before.
|
|
|
|
const streamLike = new EE();
|
|
streamLike.writableFinished = true;
|
|
streamLike.writable = true;
|
|
finished(streamLike, common.mustCall());
|
|
}
|
|
|
|
{
|
|
// Premature close if stream is not finished.
|
|
|
|
const streamLike = new EE();
|
|
streamLike.writableFinished = false;
|
|
streamLike.writable = true;
|
|
finished(streamLike, common.expectsError({
|
|
code: 'ERR_STREAM_PREMATURE_CLOSE'
|
|
}));
|
|
streamLike.emit('close');
|
|
}
|
|
|
|
{
|
|
// Premature close if stream never emitted 'finish'
|
|
// even if writableFinished says something else.
|
|
|
|
const streamLike = new EE();
|
|
streamLike.writable = true;
|
|
finished(streamLike, common.expectsError({
|
|
code: 'ERR_STREAM_PREMATURE_CLOSE'
|
|
}));
|
|
streamLike.writableFinished = true;
|
|
streamLike.emit('close');
|
|
}
|
|
|
|
|
|
{
|
|
// Premature close if stream never emitted 'end'
|
|
// even if readableEnded says something else.
|
|
|
|
const streamLike = new EE();
|
|
streamLike.readable = true;
|
|
finished(streamLike, common.expectsError({
|
|
code: 'ERR_STREAM_PREMATURE_CLOSE'
|
|
}));
|
|
streamLike.readableEnded = true;
|
|
streamLike.emit('close');
|
|
}
|
|
|
|
{
|
|
// Completes if already finished.
|
|
|
|
const w = new Writable();
|
|
finished(w, common.mustCall(() => {
|
|
finished(w, common.mustCall());
|
|
}));
|
|
w.destroy();
|
|
}
|
|
|
|
{
|
|
// Completes if already ended.
|
|
|
|
const r = new Readable();
|
|
finished(r, common.mustCall(() => {
|
|
finished(r, common.mustCall());
|
|
}));
|
|
r.destroy();
|
|
}
|
|
|
|
{
|
|
// Test is readable check through readable
|
|
const streamLike = new EE();
|
|
streamLike.readable = false;
|
|
finished(streamLike, common.mustCall());
|
|
streamLike.emit('end');
|
|
}
|
|
|
|
{
|
|
// Test is readable check through readableEnded
|
|
const streamLike = new EE();
|
|
streamLike.readableEnded = true;
|
|
finished(streamLike, common.mustCall());
|
|
streamLike.emit('end');
|
|
}
|
|
|
|
{
|
|
// Test is readable check through _readableState
|
|
const streamLike = new EE();
|
|
streamLike._readableState = {};
|
|
finished(streamLike, common.mustCall());
|
|
streamLike.emit('end');
|
|
}
|
|
|
|
{
|
|
// Test is writable check through writable
|
|
const streamLike = new EE();
|
|
streamLike.writable = false;
|
|
finished(streamLike, common.mustCall());
|
|
streamLike.emit('finish');
|
|
}
|
|
|
|
{
|
|
// Test is writable check through writableEnded
|
|
const streamLike = new EE();
|
|
streamLike.writableEnded = true;
|
|
finished(streamLike, common.mustCall());
|
|
streamLike.emit('finish');
|
|
}
|
|
|
|
{
|
|
// Test is writable check through _writableState
|
|
const streamLike = new EE();
|
|
streamLike._writableState = {};
|
|
finished(streamLike, common.mustCall());
|
|
streamLike.emit('finish');
|
|
}
|