mirror of
https://github.com/nodejs/node.git
synced 2025-05-07 15:35:41 +00:00
422e8f7628
When running the REPL as standalone program it's now possible to use
`process.on('uncaughtException', listener)`. It is going to use those
listeners from now on and the regular error output is suppressed.
It also fixes the issue that REPL instances started inside of an
application would silence all application errors. It is now prohibited
to add the exception listener in such REPL instances. Trying to add
such listeners throws an `ERR_INVALID_REPL_INPUT` error.
Fixes: https://github.com/nodejs/node/issues/19998
PR-URL: https://github.com/nodejs/node/pull/27151
Fixes: https://github.com/nodejs/node/issues/19998
Reviewed-By: Lance Ball <lball@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
73 lines
1.8 KiB
JavaScript
73 lines
1.8 KiB
JavaScript
'use strict';
|
|
require('../common');
|
|
const ArrayStream = require('../common/arraystream');
|
|
const assert = require('assert');
|
|
const repl = require('repl');
|
|
|
|
let count = 0;
|
|
|
|
function run({ command, expected }) {
|
|
let accum = '';
|
|
|
|
const output = new ArrayStream();
|
|
output.write = (data) => accum += data.replace('\r', '');
|
|
|
|
const r = repl.start({
|
|
prompt: '',
|
|
input: new ArrayStream(),
|
|
output,
|
|
terminal: false,
|
|
useColors: false
|
|
});
|
|
|
|
r.write(`${command}\n`);
|
|
if (typeof expected === 'string') {
|
|
assert.strictEqual(accum, expected);
|
|
} else {
|
|
assert(expected.test(accum), accum);
|
|
}
|
|
|
|
// Verify that the repl is still working as expected.
|
|
accum = '';
|
|
r.write('1 + 1\n');
|
|
assert.strictEqual(accum, '2\n');
|
|
r.close();
|
|
count++;
|
|
}
|
|
|
|
const tests = [
|
|
{
|
|
command: 'x',
|
|
expected: 'Thrown:\n' +
|
|
'ReferenceError: x is not defined\n'
|
|
},
|
|
{
|
|
command: 'process.on("uncaughtException", () => console.log("Foobar"));\n',
|
|
expected: /^Thrown:\nTypeError \[ERR_INVALID_REPL_INPUT]: Listeners for `/
|
|
},
|
|
{
|
|
command: 'x;\n',
|
|
expected: 'Thrown:\n' +
|
|
'ReferenceError: x is not defined\n'
|
|
},
|
|
{
|
|
command: 'process.on("uncaughtException", () => console.log("Foobar"));' +
|
|
'console.log("Baz");\n',
|
|
expected: /^Thrown:\nTypeError \[ERR_INVALID_REPL_INPUT]: Listeners for `/
|
|
},
|
|
{
|
|
command: 'console.log("Baz");' +
|
|
'process.on("uncaughtException", () => console.log("Foobar"));\n',
|
|
expected: /^Baz\nThrown:\nTypeError \[ERR_INVALID_REPL_INPUT]:.*uncaughtException/
|
|
}
|
|
];
|
|
|
|
process.on('exit', () => {
|
|
// To actually verify that the test passed we have to make sure no
|
|
// `uncaughtException` listeners exist anymore.
|
|
process.removeAllListeners('uncaughtException');
|
|
assert.strictEqual(count, tests.length);
|
|
});
|
|
|
|
tests.forEach(run);
|