mirror of
https://github.com/nodejs/node.git
synced 2025-05-07 17:32:22 +00:00
cdd3833bca
This test currently fails if run as root:
npm ERR! makeDirectory homeless?
npm WARN install-dir No description
npm WARN install-dir No repository field.
npm WARN install-dir No license field.
npm ERR! path /root/node/test/.tmp.0/npm-sandbox/home
npm ERR! code ENOENT
npm ERR! errno -2
npm ERR! syscall stat
npm ERR! enoent ENOENT:
no such file or directory,
stat '/root/node/test/.tmp.0/npm-sandbox/home'
npm ERR! enoent This is related to npm not being able to find a file.
npm ERR! enoent
assert.js:89
throw new AssertionError(obj);
^
AssertionError [ERR_ASSERTION]: npm install got error code 254
at handleExit (/root/node/test/parallel/test-npm-install.js:60:10)
at /root/node/test/common/index.js:371:15
at ChildProcess.exithandler (child_process.js:304:5)
at ChildProcess.emit (events.js:203:13)
at maybeClose (internal/child_process.js:1028:16)
at Process.ChildProcess._handle.onexit
(internal/child_process.js:283:5) {
generatedMessage: false,
code: 'ERR_ASSERTION',
actual: 254,
expected: 0,
operator: 'strictEqual'
}
The home directory will be created as expected by npm in the npmSandbox
when run as non-root, but when run as root this directory has to exist.
This commit creates the home directory to allow the test to pass also
when run as the root user.
Refs:https://github.com/npm/cli/blob/
31718e72cb5a03cee7127fc36843e4b55c868d93/
lib/utils/correct-mkdir.js#L82-L105
PR-URL: https://github.com/nodejs/node/pull/28510
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
65 lines
1.6 KiB
JavaScript
65 lines
1.6 KiB
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
if (!common.hasCrypto)
|
|
common.skip('missing crypto');
|
|
|
|
const path = require('path');
|
|
const exec = require('child_process').exec;
|
|
const assert = require('assert');
|
|
const fs = require('fs');
|
|
const fixtures = require('../common/fixtures');
|
|
|
|
const tmpdir = require('../common/tmpdir');
|
|
tmpdir.refresh();
|
|
const npmSandbox = path.join(tmpdir.path, 'npm-sandbox');
|
|
fs.mkdirSync(npmSandbox);
|
|
const homeDir = path.join(tmpdir.path, 'home');
|
|
fs.mkdirSync(homeDir);
|
|
const installDir = path.join(tmpdir.path, 'install-dir');
|
|
fs.mkdirSync(installDir);
|
|
|
|
const npmPath = path.join(
|
|
__dirname,
|
|
'..',
|
|
'..',
|
|
'deps',
|
|
'npm',
|
|
'bin',
|
|
'npm-cli.js'
|
|
);
|
|
|
|
const pkgContent = JSON.stringify({
|
|
dependencies: {
|
|
'package-name': fixtures.path('packages/main')
|
|
}
|
|
});
|
|
|
|
const pkgPath = path.join(installDir, 'package.json');
|
|
|
|
fs.writeFileSync(pkgPath, pkgContent);
|
|
|
|
const env = Object.assign({}, process.env, {
|
|
PATH: path.dirname(process.execPath),
|
|
NPM_CONFIG_PREFIX: path.join(npmSandbox, 'npm-prefix'),
|
|
NPM_CONFIG_TMP: path.join(npmSandbox, 'npm-tmp'),
|
|
HOME: homeDir,
|
|
});
|
|
|
|
exec(`${process.execPath} ${npmPath} install`, {
|
|
cwd: installDir,
|
|
env: env
|
|
}, common.mustCall(handleExit));
|
|
|
|
function handleExit(error, stdout, stderr) {
|
|
const code = error ? error.code : 0;
|
|
const signalCode = error ? error.signal : null;
|
|
|
|
if (code !== 0) {
|
|
process.stderr.write(stderr);
|
|
}
|
|
|
|
assert.strictEqual(code, 0, `npm install got error code ${code}`);
|
|
assert.strictEqual(signalCode, null, `unexpected signal: ${signalCode}`);
|
|
assert(fs.existsSync(`${installDir}/node_modules/package-name`));
|
|
}
|