mirror of
https://github.com/nodejs/node.git
synced 2025-05-07 17:32:22 +00:00
96204c3c71
The error provided in this function could come from user code. Thus the error should not be manipulated in any way. The added properties do not seem to provide any actual value either as can not be part of the error. The `hostname` is already set on the error and adding the `host` property with the identical value does not seem right in this case. PR-URL: https://github.com/nodejs/node/pull/26751 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
55 lines
2.0 KiB
JavaScript
55 lines
2.0 KiB
JavaScript
// Copyright Joyent, Inc. and other Node contributors.
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a
|
|
// copy of this software and associated documentation files (the
|
|
// "Software"), to deal in the Software without restriction, including
|
|
// without limitation the rights to use, copy, modify, merge, publish,
|
|
// distribute, sublicense, and/or sell copies of the Software, and to permit
|
|
// persons to whom the Software is furnished to do so, subject to the
|
|
// following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included
|
|
// in all copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
|
|
// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
|
|
// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN
|
|
// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
|
|
// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
|
|
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
|
|
// USE OR OTHER DEALINGS IN THE SOFTWARE.
|
|
|
|
'use strict';
|
|
|
|
// This tests that if the socket is still in the 'connecting' state
|
|
// when the user calls socket.end() ('finish'), the socket would emit
|
|
// 'connect' and defer the handling until the 'connect' event is handled.
|
|
|
|
const common = require('../common');
|
|
const net = require('net');
|
|
|
|
const { addresses } = require('../common/internet');
|
|
const {
|
|
errorLookupMock,
|
|
mockedErrorCode,
|
|
mockedSysCall
|
|
} = require('../common/dns');
|
|
|
|
const client = net.connect({
|
|
host: addresses.INVALID_HOST,
|
|
port: 80, // Port number doesn't matter because host name is invalid
|
|
lookup: common.mustCall(errorLookupMock())
|
|
}, common.mustNotCall());
|
|
|
|
client.once('error', common.expectsError({
|
|
code: mockedErrorCode,
|
|
errno: mockedErrorCode,
|
|
syscall: mockedSysCall,
|
|
hostname: addresses.INVALID_HOST,
|
|
message: 'getaddrinfo ENOTFOUND something.invalid',
|
|
port: undefined,
|
|
host: undefined
|
|
}));
|
|
|
|
client.end();
|