mirror of
https://github.com/nodejs/node.git
synced 2025-05-07 23:17:19 +00:00
df08779e0d
This commit removes `common.crashOnUnhandledRejection()` and adds `common.disableCrashOnUnhandledRejection()`. To reduce the risk of mistakes and make writing tests that involve promises simpler, always install the unhandledRejection hook in tests and provide a way to disable it for the rare cases where it's needed. PR-URL: https://github.com/nodejs/node/pull/21849 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
74 lines
2.2 KiB
JavaScript
74 lines
2.2 KiB
JavaScript
// Flags: --expose-internals
|
|
'use strict';
|
|
const common = require('../common');
|
|
|
|
common.skipIfInspectorDisabled();
|
|
|
|
const { NodeInstance } = require('../common/inspector-helper.js');
|
|
|
|
// Sets up JS bindings session and runs till the "paused" event
|
|
const script = `
|
|
const { Session } = require('inspector');
|
|
const session = new Session();
|
|
let done = false;
|
|
const interval = setInterval(() => {
|
|
if (done)
|
|
clearInterval(interval);
|
|
}, 150);
|
|
session.on('Debugger.paused', () => {
|
|
done = true;
|
|
});
|
|
session.connect();
|
|
session.post('Debugger.enable');
|
|
console.log('Ready');
|
|
`;
|
|
|
|
async function setupSession(node) {
|
|
const session = await node.connectInspectorSession();
|
|
await session.send([
|
|
{ 'method': 'Runtime.enable' },
|
|
{ 'method': 'Debugger.enable' },
|
|
{ 'method': 'Debugger.setPauseOnExceptions',
|
|
'params': { 'state': 'none' } },
|
|
{ 'method': 'Debugger.setAsyncCallStackDepth',
|
|
'params': { 'maxDepth': 0 } },
|
|
{ 'method': 'Profiler.enable' },
|
|
{ 'method': 'Profiler.setSamplingInterval',
|
|
'params': { 'interval': 100 } },
|
|
{ 'method': 'Debugger.setBlackboxPatterns',
|
|
'params': { 'patterns': [] } },
|
|
{ 'method': 'Runtime.runIfWaitingForDebugger' }
|
|
]);
|
|
return session;
|
|
}
|
|
|
|
async function testSuspend(sessionA, sessionB) {
|
|
console.log('[test]', 'Breaking in code and verifying events are fired');
|
|
await sessionA.waitForNotification('Debugger.paused', 'Initial pause');
|
|
sessionA.send({ 'method': 'Debugger.resume' });
|
|
|
|
await sessionA.waitForNotification('Runtime.consoleAPICalled',
|
|
'Console output');
|
|
sessionA.send({ 'method': 'Debugger.pause' });
|
|
return Promise.all([
|
|
sessionA.waitForNotification('Debugger.paused', 'SessionA paused'),
|
|
sessionB.waitForNotification('Debugger.paused', 'SessionB paused')
|
|
]);
|
|
}
|
|
|
|
async function runTest() {
|
|
const child = new NodeInstance(undefined, script);
|
|
|
|
const [session1, session2] =
|
|
await Promise.all([setupSession(child), setupSession(child)]);
|
|
await testSuspend(session2, session1);
|
|
console.log('[test]', 'Should shut down after both sessions disconnect');
|
|
|
|
await session1.runToCompletion();
|
|
await session2.send({ 'method': 'Debugger.disable' });
|
|
await session2.disconnect();
|
|
return child.expectShutdown();
|
|
}
|
|
|
|
runTest();
|