mirror of
https://github.com/nodejs/node.git
synced 2025-05-07 15:35:41 +00:00
df08779e0d
This commit removes `common.crashOnUnhandledRejection()` and adds `common.disableCrashOnUnhandledRejection()`. To reduce the risk of mistakes and make writing tests that involve promises simpler, always install the unhandledRejection hook in tests and provide a way to disable it for the rare cases where it's needed. PR-URL: https://github.com/nodejs/node/pull/21849 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
71 lines
2.4 KiB
JavaScript
71 lines
2.4 KiB
JavaScript
// Flags: --expose-internals
|
|
'use strict';
|
|
const common = require('../common');
|
|
common.skipIfInspectorDisabled();
|
|
common.skipIf32Bits();
|
|
const { NodeInstance } = require('../common/inspector-helper.js');
|
|
const assert = require('assert');
|
|
|
|
// Even with --inspect, the default async call stack depth is 0. We need a
|
|
// chance to call Debugger.setAsyncCallStackDepth *before* activating the timer
|
|
// for async stack traces to work.
|
|
const script = `
|
|
process._rawDebug('Waiting until the inspector is activated...');
|
|
const waiting = setInterval(() => { debugger; }, 50);
|
|
|
|
// This function is called by the inspector client (session)
|
|
function setupTimeoutWithBreak() {
|
|
clearInterval(waiting);
|
|
process._rawDebug('Debugger ready, setting up timeout with a break');
|
|
setTimeout(() => { debugger; }, 50);
|
|
}
|
|
`;
|
|
|
|
async function waitForInitialSetup(session) {
|
|
console.error('[test]', 'Waiting for initial setup');
|
|
await session.waitForBreakOnLine(2, '[eval]');
|
|
}
|
|
|
|
async function setupTimeoutForStackTrace(session) {
|
|
console.error('[test]', 'Setting up timeout for async stack trace');
|
|
await session.send([
|
|
{ 'method': 'Runtime.evaluate',
|
|
'params': { expression: 'setupTimeoutWithBreak()' } },
|
|
{ 'method': 'Debugger.resume' }
|
|
]);
|
|
}
|
|
|
|
async function checkAsyncStackTrace(session) {
|
|
console.error('[test]', 'Verify basic properties of asyncStackTrace');
|
|
const paused = await session.waitForBreakOnLine(8, '[eval]');
|
|
assert(paused.params.asyncStackTrace,
|
|
`${Object.keys(paused.params)} contains "asyncStackTrace" property`);
|
|
assert(paused.params.asyncStackTrace.description, 'Timeout');
|
|
assert(paused.params.asyncStackTrace.callFrames
|
|
.some((frame) => frame.functionName === 'setupTimeoutWithBreak'));
|
|
}
|
|
|
|
async function runTests() {
|
|
const instance = new NodeInstance(['--inspect=0'], script);
|
|
const session = await instance.connectInspectorSession();
|
|
await session.send([
|
|
{ 'method': 'Runtime.enable' },
|
|
{ 'method': 'Debugger.enable' },
|
|
{ 'method': 'Debugger.setAsyncCallStackDepth',
|
|
'params': { 'maxDepth': 10 } },
|
|
{ 'method': 'Debugger.setBlackboxPatterns',
|
|
'params': { 'patterns': [] } },
|
|
{ 'method': 'Runtime.runIfWaitingForDebugger' }
|
|
]);
|
|
|
|
await waitForInitialSetup(session);
|
|
await setupTimeoutForStackTrace(session);
|
|
await checkAsyncStackTrace(session);
|
|
|
|
console.error('[test]', 'Stopping child instance');
|
|
session.disconnect();
|
|
instance.kill();
|
|
}
|
|
|
|
runTests();
|