node/test/parallel/test-http2-server-shutdown-options-errors.js
Anatoli Papirovski b11e19e8ee
http2: fix several serious bugs
Currently http2 does not properly submit GOAWAY frames when a session
is being destroyed. It also doesn't properly handle when the other
party severs the connection after sending a GOAWAY frame, even though
it should.

Edge, IE & Safari are currently unable to handle empty TRAILERS
frames despite them being correctly to spec. Instead send an empty
DATA frame with END_STREAM flag in those situations.

Fix and adjust several flaky and/or incorrect tests.

PR-URL: https://github.com/nodejs/node/pull/20772
Fixes: https://github.com/nodejs/node/issues/20705
Fixes: https://github.com/nodejs/node/issues/20750
Fixes: https://github.com/nodejs/node/issues/20850
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2018-05-22 11:42:33 +04:00

66 lines
1.5 KiB
JavaScript

'use strict';
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const http2 = require('http2');
const server = http2.createServer();
const types = [
true,
{},
[],
null,
new Date()
];
server.on('stream', common.mustCall((stream) => {
const session = stream.session;
types.forEach((input) => {
common.expectsError(
() => session.goaway(input),
{
code: 'ERR_INVALID_ARG_TYPE',
type: TypeError,
message: 'The "code" argument must be of type number. Received type ' +
typeof input
}
);
common.expectsError(
() => session.goaway(0, input),
{
code: 'ERR_INVALID_ARG_TYPE',
type: TypeError,
message: 'The "lastStreamID" argument must be of type number. ' +
`Received type ${typeof input}`
}
);
common.expectsError(
() => session.goaway(0, 0, input),
{
code: 'ERR_INVALID_ARG_TYPE',
type: TypeError,
message: 'The "opaqueData" argument must be one of type Buffer, ' +
`TypedArray, or DataView. Received type ${typeof input}`
}
);
});
stream.session.destroy();
}));
server.listen(
0,
common.mustCall(() => {
const client = http2.connect(`http://localhost:${server.address().port}`);
const req = client.request();
req.resume();
req.on('close', common.mustCall(() => {
client.close();
server.close();
}));
})
);