mirror of
https://github.com/nodejs/node.git
synced 2025-05-07 17:32:22 +00:00

Currently http2 does not properly submit GOAWAY frames when a session is being destroyed. It also doesn't properly handle when the other party severs the connection after sending a GOAWAY frame, even though it should. Edge, IE & Safari are currently unable to handle empty TRAILERS frames despite them being correctly to spec. Instead send an empty DATA frame with END_STREAM flag in those situations. Fix and adjust several flaky and/or incorrect tests. PR-URL: https://github.com/nodejs/node/pull/20772 Fixes: https://github.com/nodejs/node/issues/20705 Fixes: https://github.com/nodejs/node/issues/20750 Fixes: https://github.com/nodejs/node/issues/20850 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
28 lines
621 B
JavaScript
28 lines
621 B
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
if (!common.hasCrypto)
|
|
common.skip('missing crypto');
|
|
|
|
const Countdown = require('../common/countdown');
|
|
const http2 = require('http2');
|
|
|
|
const server = http2.createServer();
|
|
|
|
let session;
|
|
|
|
const countdown = new Countdown(2, () => {
|
|
server.close(common.mustCall());
|
|
session.destroy();
|
|
});
|
|
|
|
server.listen(0, common.mustCall(() => {
|
|
const client = http2.connect(`http://localhost:${server.address().port}`);
|
|
client.on('connect', common.mustCall(() => countdown.dec()));
|
|
}));
|
|
|
|
server.on('session', common.mustCall((s) => {
|
|
session = s;
|
|
countdown.dec();
|
|
}));
|