mirror of
https://github.com/nodejs/node.git
synced 2025-05-07 19:56:48 +00:00
c6b6c92185
This makes a effort to make sure all of these errors will actually also show the received input. On top of that it refactors a few tests for better maintainability. It will also change the returned type to always be a simple typeof instead of special handling null. PR-URL: https://github.com/nodejs/node/pull/19445 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
77 lines
2.0 KiB
JavaScript
77 lines
2.0 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
if (!common.hasCrypto)
|
|
common.skip('missing crypto');
|
|
const assert = require('assert');
|
|
const http2 = require('http2');
|
|
|
|
const server = http2.createServer();
|
|
server.listen(0, common.mustCall(() => {
|
|
const port = server.address().port;
|
|
server.once('request', common.mustCall((request, response) => {
|
|
response.addTrailers({
|
|
ABC: 123
|
|
});
|
|
response.setTrailer('ABCD', 123);
|
|
|
|
common.expectsError(
|
|
() => response.addTrailers({ '': 'test' }),
|
|
{
|
|
code: 'ERR_INVALID_HTTP_TOKEN',
|
|
type: TypeError,
|
|
message: 'Header name must be a valid HTTP token [""]'
|
|
}
|
|
);
|
|
common.expectsError(
|
|
() => response.setTrailer('test', undefined),
|
|
{
|
|
code: 'ERR_HTTP2_INVALID_HEADER_VALUE',
|
|
type: TypeError,
|
|
message: 'Invalid value "undefined" for header "test"'
|
|
}
|
|
);
|
|
common.expectsError(
|
|
() => response.setTrailer('test', null),
|
|
{
|
|
code: 'ERR_HTTP2_INVALID_HEADER_VALUE',
|
|
type: TypeError,
|
|
message: 'Invalid value "null" for header "test"'
|
|
}
|
|
);
|
|
common.expectsError(
|
|
() => response.setTrailer(), // Trailer name undefined
|
|
{
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
type: TypeError,
|
|
message: 'The "name" argument must be of type string. Received type ' +
|
|
'undefined'
|
|
}
|
|
);
|
|
common.expectsError(
|
|
() => response.setTrailer(''),
|
|
{
|
|
code: 'ERR_INVALID_HTTP_TOKEN',
|
|
type: TypeError,
|
|
message: 'Header name must be a valid HTTP token [""]'
|
|
}
|
|
);
|
|
|
|
response.end('hello');
|
|
}));
|
|
|
|
const url = `http://localhost:${port}`;
|
|
const client = http2.connect(url, common.mustCall(() => {
|
|
const request = client.request();
|
|
request.on('trailers', common.mustCall((headers) => {
|
|
assert.strictEqual(headers.abc, '123');
|
|
assert.strictEqual(headers.abcd, '123');
|
|
}));
|
|
request.resume();
|
|
request.on('end', common.mustCall(() => {
|
|
client.close();
|
|
server.close();
|
|
}));
|
|
}));
|
|
}));
|