node/test/parallel/test-http2-compat-serverresponse-statuscode.js
Ruben Bridgewater 644fdd60d4
test: minor refactoring
Add punctuation and comments about code that should not throw.
Also remove a obsolete test and refactor some tests.

PR-URL: https://github.com/nodejs/node/pull/18669
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
2018-02-16 16:54:07 +01:00

77 lines
2.1 KiB
JavaScript

'use strict';
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const assert = require('assert');
const h2 = require('http2');
// Http2ServerResponse should have a statusCode property
const server = h2.createServer();
server.listen(0, common.mustCall(function() {
const port = server.address().port;
server.once('request', common.mustCall(function(request, response) {
const expectedDefaultStatusCode = 200;
const realStatusCodes = {
continue: 100,
ok: 200,
multipleChoices: 300,
badRequest: 400,
internalServerError: 500
};
const fakeStatusCodes = {
tooLow: 99,
tooHigh: 600
};
assert.strictEqual(response.statusCode, expectedDefaultStatusCode);
// Setting the response.statusCode should not throw.
response.statusCode = realStatusCodes.ok;
response.statusCode = realStatusCodes.multipleChoices;
response.statusCode = realStatusCodes.badRequest;
response.statusCode = realStatusCodes.internalServerError;
common.expectsError(function() {
response.statusCode = realStatusCodes.continue;
}, {
code: 'ERR_HTTP2_INFO_STATUS_NOT_ALLOWED',
type: RangeError
});
common.expectsError(function() {
response.statusCode = fakeStatusCodes.tooLow;
}, {
code: 'ERR_HTTP2_STATUS_INVALID',
type: RangeError
});
common.expectsError(function() {
response.statusCode = fakeStatusCodes.tooHigh;
}, {
code: 'ERR_HTTP2_STATUS_INVALID',
type: RangeError
});
response.on('finish', common.mustCall(function() {
server.close();
}));
response.end();
}));
const url = `http://localhost:${port}`;
const client = h2.connect(url, common.mustCall(function() {
const headers = {
':path': '/',
':method': 'GET',
':scheme': 'http',
':authority': `localhost:${port}`
};
const request = client.request(headers);
request.on('end', common.mustCall(function() {
client.close();
}));
request.end();
request.resume();
}));
}));