mirror of
https://github.com/nodejs/node.git
synced 2025-05-07 12:03:30 +00:00
de4600ea2b
Fix a bug where a connection upgrade response with a Transfer-Encoding header and a body whose first byte is > 127 causes said byte to be dropped on the floor when passing the remainder of the message to the 'upgrade' event listeners. Fixes: https://github.com/nodejs/node/issues/17789 PR-URL: https://github.com/nodejs/node/pull/17806 Fixes: https://github.com/nodejs/node/issues/17789 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
29 lines
992 B
JavaScript
29 lines
992 B
JavaScript
'use strict';
|
|
const { mustCall } = require('../common');
|
|
const assert = require('assert');
|
|
const http = require('http');
|
|
const net = require('net');
|
|
|
|
// https://github.com/nodejs/node/issues/17789 - a connection upgrade response
|
|
// that has a Transfer-Encoding header and a body whose first byte is > 127
|
|
// triggers a bug where said byte is skipped over.
|
|
net.createServer(mustCall(function(conn) {
|
|
conn.write('HTTP/1.1 101 Switching Protocols\r\n' +
|
|
'Connection: upgrade\r\n' +
|
|
'Transfer-Encoding: chunked\r\n' +
|
|
'Upgrade: websocket\r\n' +
|
|
'\r\n' +
|
|
'\u0080', 'latin1');
|
|
this.close();
|
|
})).listen(0, mustCall(function() {
|
|
http.get({
|
|
host: this.address().host,
|
|
port: this.address().port,
|
|
headers: { 'Connection': 'upgrade', 'Upgrade': 'websocket' },
|
|
}).on('upgrade', mustCall((res, conn, head) => {
|
|
assert.strictEqual(head.length, 1);
|
|
assert.strictEqual(head[0], 128);
|
|
conn.destroy();
|
|
}));
|
|
}));
|