node/test/parallel/test-http-server-destroy-socket-on-client-error.js
Anna Henningsen ba565a3734 http: improve parser error messages
Include the library-provided reason in the Error’s `message`.

Fixes: https://github.com/nodejs/node/issues/28468

PR-URL: https://github.com/nodejs/node/pull/28487
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
2019-07-05 22:36:53 -07:00

48 lines
1.1 KiB
JavaScript

'use strict';
const { expectsError, mustCall } = require('../common');
// Test that the request socket is destroyed if the `'clientError'` event is
// emitted and there is no listener for it.
const assert = require('assert');
const { createServer } = require('http');
const { createConnection } = require('net');
const server = createServer();
server.on('connection', mustCall((socket) => {
socket.on('error', expectsError({
type: Error,
message: 'Parse Error: Invalid method encountered',
code: 'HPE_INVALID_METHOD',
bytesParsed: 0,
rawPacket: Buffer.from('FOO /\r\n')
}));
}));
server.listen(0, () => {
const chunks = [];
const socket = createConnection({
allowHalfOpen: true,
port: server.address().port
});
socket.on('connect', mustCall(() => {
socket.write('FOO /\r\n');
}));
socket.on('data', (chunk) => {
chunks.push(chunk);
});
socket.on('end', mustCall(() => {
const expected = Buffer.from(
'HTTP/1.1 400 Bad Request\r\nConnection: close\r\n\r\n'
);
assert(Buffer.concat(chunks).equals(expected));
server.close();
}));
});