node/test/parallel/test-http-client-reject-unexpected-agent.js
Ruben Bridgewater b38c81cb44
lib: improve error handling
This improves the error handling for a couple cases where the
received value would not have been handled so far or where the name
is wrong etc.

PR-URL: https://github.com/nodejs/node/pull/19445
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
2018-03-25 03:01:45 +02:00

69 lines
1.4 KiB
JavaScript

'use strict';
const common = require('../common');
const assert = require('assert');
const http = require('http');
const baseOptions = {
method: 'GET',
port: undefined,
host: common.localhostIPv4,
};
const failingAgentOptions = [
true,
'agent',
{},
1,
() => null,
Symbol(),
];
const acceptableAgentOptions = [
false,
undefined,
null,
new http.Agent(),
];
const server = http.createServer((req, res) => {
res.end('hello');
});
let numberOfResponses = 0;
function createRequest(agent) {
const options = Object.assign(baseOptions, { agent });
const request = http.request(options);
request.end();
request.on('response', common.mustCall(() => {
numberOfResponses++;
if (numberOfResponses === acceptableAgentOptions.length) {
server.close();
}
}));
}
server.listen(0, baseOptions.host, common.mustCall(function() {
baseOptions.port = this.address().port;
failingAgentOptions.forEach((agent) => {
common.expectsError(
() => createRequest(agent),
{
code: 'ERR_INVALID_ARG_TYPE',
type: TypeError,
message: 'The "options.agent" property must be one of type Agent-like' +
` Object, undefined, or false. Received type ${typeof agent}`
}
);
});
acceptableAgentOptions.forEach((agent) => {
createRequest(agent);
});
}));
process.on('exit', () => {
assert.strictEqual(numberOfResponses, acceptableAgentOptions.length);
});