mirror of
https://github.com/nodejs/node.git
synced 2025-05-07 13:47:16 +00:00
cda6b20816
On Windows creating a symlink to a directory will not work unless extra 'dir' parameter is passed. This adds a check if link target is a directory, and if so automatically use 'dir' when creating symlink. PR-URL: https://github.com/nodejs/node/pull/23724 Refs: https://github.com/nodejs/node/pull/23691 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
47 lines
1.2 KiB
JavaScript
47 lines
1.2 KiB
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
|
|
// Test creating a symbolic link pointing to a directory.
|
|
// Ref: https://github.com/nodejs/node/pull/23724
|
|
// Ref: https://github.com/nodejs/node/issues/23596
|
|
|
|
|
|
if (!common.canCreateSymLink())
|
|
common.skip('insufficient privileges');
|
|
|
|
const assert = require('assert');
|
|
const path = require('path');
|
|
const fs = require('fs');
|
|
|
|
const tmpdir = require('../common/tmpdir');
|
|
tmpdir.refresh();
|
|
|
|
const linkTargets = [
|
|
'relative-target',
|
|
path.join(tmpdir.path, 'absolute-target')
|
|
];
|
|
const linkPaths = [
|
|
path.relative(process.cwd(), path.join(tmpdir.path, 'relative-path')),
|
|
path.join(tmpdir.path, 'absolute-path')
|
|
];
|
|
|
|
function testSync(target, path) {
|
|
fs.symlinkSync(target, path);
|
|
fs.readdirSync(path);
|
|
}
|
|
|
|
function testAsync(target, path) {
|
|
fs.symlink(target, path, common.mustCall((err) => {
|
|
assert.ifError(err);
|
|
fs.readdirSync(path);
|
|
}));
|
|
}
|
|
|
|
for (const linkTarget of linkTargets) {
|
|
fs.mkdirSync(path.resolve(tmpdir.path, linkTarget));
|
|
for (const linkPath of linkPaths) {
|
|
testSync(linkTarget, `${linkPath}-${path.basename(linkTarget)}-sync`);
|
|
testAsync(linkTarget, `${linkPath}-${path.basename(linkTarget)}-async`);
|
|
}
|
|
}
|