mirror of
https://github.com/nodejs/node.git
synced 2025-05-07 13:47:16 +00:00

- Extend the aliased buffer for stats objects to contain the entire time spec (seconds and nanoseconds) for the time values instead of calculating the milliseconds in C++ and lose precision there. - Calculate the nanosecond-precision time values in JS and expose them in BigInt Stats objects as `*timeNs`. The millisecond-precision values are now calculated from the nanosecond-precision values. PR-URL: https://github.com/nodejs/node/pull/21387 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gus Caplan <me@gus.host>
179 lines
5.2 KiB
JavaScript
179 lines
5.2 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const fs = require('fs');
|
|
const promiseFs = require('fs').promises;
|
|
const path = require('path');
|
|
const tmpdir = require('../common/tmpdir');
|
|
const { isDate } = require('util').types;
|
|
const { inspect } = require('util');
|
|
|
|
tmpdir.refresh();
|
|
|
|
let testIndex = 0;
|
|
|
|
function getFilename() {
|
|
const filename = path.join(tmpdir.path, `test-file-${++testIndex}`);
|
|
fs.writeFileSync(filename, 'test');
|
|
return filename;
|
|
}
|
|
|
|
function verifyStats(bigintStats, numStats) {
|
|
for (const key of Object.keys(numStats)) {
|
|
const val = numStats[key];
|
|
if (isDate(val)) {
|
|
const time = val.getTime();
|
|
const time2 = bigintStats[key].getTime();
|
|
assert(
|
|
Math.abs(time - time2) < 2,
|
|
`difference of ${key}.getTime() should < 2.\n` +
|
|
`Number version ${time}, BigInt version ${time2}n`);
|
|
} else if (key === 'mode') {
|
|
assert.strictEqual(bigintStats[key], BigInt(val));
|
|
assert.strictEqual(
|
|
bigintStats.isBlockDevice(),
|
|
numStats.isBlockDevice()
|
|
);
|
|
assert.strictEqual(
|
|
bigintStats.isCharacterDevice(),
|
|
numStats.isCharacterDevice()
|
|
);
|
|
assert.strictEqual(
|
|
bigintStats.isDirectory(),
|
|
numStats.isDirectory()
|
|
);
|
|
assert.strictEqual(
|
|
bigintStats.isFIFO(),
|
|
numStats.isFIFO()
|
|
);
|
|
assert.strictEqual(
|
|
bigintStats.isFile(),
|
|
numStats.isFile()
|
|
);
|
|
assert.strictEqual(
|
|
bigintStats.isSocket(),
|
|
numStats.isSocket()
|
|
);
|
|
assert.strictEqual(
|
|
bigintStats.isSymbolicLink(),
|
|
numStats.isSymbolicLink()
|
|
);
|
|
} else if (key.endsWith('Ms')) {
|
|
const nsKey = key.replace('Ms', 'Ns');
|
|
const msFromBigInt = bigintStats[key];
|
|
const nsFromBigInt = bigintStats[nsKey];
|
|
const msFromBigIntNs = Number(nsFromBigInt / (10n ** 6n));
|
|
const msFromNum = numStats[key];
|
|
// The difference between the millisecond-precision values should be
|
|
// smaller than 2
|
|
assert(
|
|
Math.abs(msFromNum - Number(msFromBigInt)) < 2,
|
|
`Number version ${key} = ${msFromNum}, ` +
|
|
`BigInt version ${key} = ${msFromBigInt}n`);
|
|
// The difference between the millisecond-precision value and the
|
|
// nanosecond-precision value scaled down to milliseconds should be
|
|
// smaller than 2
|
|
assert(
|
|
Math.abs(msFromNum - Number(msFromBigIntNs)) < 2,
|
|
`Number version ${key} = ${msFromNum}, ` +
|
|
`BigInt version ${nsKey} = ${nsFromBigInt}n` +
|
|
` = ${msFromBigIntNs}ms`);
|
|
} else if (Number.isSafeInteger(val)) {
|
|
assert.strictEqual(
|
|
bigintStats[key], BigInt(val),
|
|
`${inspect(bigintStats[key])} !== ${inspect(BigInt(val))}\n` +
|
|
`key=${key}, val=${val}`
|
|
);
|
|
} else {
|
|
assert(
|
|
Math.abs(Number(bigintStats[key]) - val) < 1,
|
|
`${key} is not a safe integer, difference should < 1.\n` +
|
|
`Number version ${val}, BigInt version ${bigintStats[key]}n`);
|
|
}
|
|
}
|
|
}
|
|
|
|
{
|
|
const filename = getFilename();
|
|
const bigintStats = fs.statSync(filename, { bigint: true });
|
|
const numStats = fs.statSync(filename);
|
|
verifyStats(bigintStats, numStats);
|
|
}
|
|
|
|
if (!common.isWindows) {
|
|
const filename = getFilename();
|
|
const link = `${filename}-link`;
|
|
fs.symlinkSync(filename, link);
|
|
const bigintStats = fs.lstatSync(link, { bigint: true });
|
|
const numStats = fs.lstatSync(link);
|
|
verifyStats(bigintStats, numStats);
|
|
}
|
|
|
|
{
|
|
const filename = getFilename();
|
|
const fd = fs.openSync(filename, 'r');
|
|
const bigintStats = fs.fstatSync(fd, { bigint: true });
|
|
const numStats = fs.fstatSync(fd);
|
|
verifyStats(bigintStats, numStats);
|
|
fs.closeSync(fd);
|
|
}
|
|
|
|
{
|
|
const filename = getFilename();
|
|
fs.stat(filename, { bigint: true }, (err, bigintStats) => {
|
|
fs.stat(filename, (err, numStats) => {
|
|
verifyStats(bigintStats, numStats);
|
|
});
|
|
});
|
|
}
|
|
|
|
if (!common.isWindows) {
|
|
const filename = getFilename();
|
|
const link = `${filename}-link`;
|
|
fs.symlinkSync(filename, link);
|
|
fs.lstat(link, { bigint: true }, (err, bigintStats) => {
|
|
fs.lstat(link, (err, numStats) => {
|
|
verifyStats(bigintStats, numStats);
|
|
});
|
|
});
|
|
}
|
|
|
|
{
|
|
const filename = getFilename();
|
|
const fd = fs.openSync(filename, 'r');
|
|
fs.fstat(fd, { bigint: true }, (err, bigintStats) => {
|
|
fs.fstat(fd, (err, numStats) => {
|
|
verifyStats(bigintStats, numStats);
|
|
fs.closeSync(fd);
|
|
});
|
|
});
|
|
}
|
|
|
|
(async function() {
|
|
const filename = getFilename();
|
|
const bigintStats = await promiseFs.stat(filename, { bigint: true });
|
|
const numStats = await promiseFs.stat(filename);
|
|
verifyStats(bigintStats, numStats);
|
|
})();
|
|
|
|
if (!common.isWindows) {
|
|
(async function() {
|
|
const filename = getFilename();
|
|
const link = `${filename}-link`;
|
|
fs.symlinkSync(filename, link);
|
|
const bigintStats = await promiseFs.lstat(link, { bigint: true });
|
|
const numStats = await promiseFs.lstat(link);
|
|
verifyStats(bigintStats, numStats);
|
|
})();
|
|
}
|
|
|
|
(async function() {
|
|
const filename = getFilename();
|
|
const handle = await promiseFs.open(filename, 'r');
|
|
const bigintStats = await handle.stat({ bigint: true });
|
|
const numStats = await handle.stat();
|
|
verifyStats(bigintStats, numStats);
|
|
await handle.close();
|
|
})();
|