mirror of
https://github.com/nodejs/node.git
synced 2025-05-07 17:32:22 +00:00
df08779e0d
This commit removes `common.crashOnUnhandledRejection()` and adds `common.disableCrashOnUnhandledRejection()`. To reduce the risk of mistakes and make writing tests that involve promises simpler, always install the unhandledRejection hook in tests and provide a way to disable it for the rare cases where it's needed. PR-URL: https://github.com/nodejs/node/pull/21849 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
66 lines
2.0 KiB
JavaScript
66 lines
2.0 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
const tmpdir = require('../common/tmpdir');
|
|
const assert = require('assert');
|
|
const fs = require('fs');
|
|
const path = require('path');
|
|
const { promises } = fs;
|
|
|
|
// Validate the path argument.
|
|
[false, 1, {}, [], null, undefined].forEach((i) => {
|
|
const err = { type: TypeError, code: 'ERR_INVALID_ARG_TYPE' };
|
|
|
|
common.expectsError(() => fs.lchown(i, 1, 1, common.mustNotCall()), err);
|
|
common.expectsError(() => fs.lchownSync(i, 1, 1), err);
|
|
promises.lchown(false, 1, 1)
|
|
.then(common.mustNotCall())
|
|
.catch(common.expectsError(err));
|
|
});
|
|
|
|
// Validate the uid and gid arguments.
|
|
[false, 'test', {}, [], null, undefined].forEach((i) => {
|
|
const err = { type: TypeError, code: 'ERR_INVALID_ARG_TYPE' };
|
|
|
|
common.expectsError(
|
|
() => fs.lchown('not_a_file_that_exists', i, 1, common.mustNotCall()),
|
|
err
|
|
);
|
|
common.expectsError(
|
|
() => fs.lchown('not_a_file_that_exists', 1, i, common.mustNotCall()),
|
|
err
|
|
);
|
|
common.expectsError(() => fs.lchownSync('not_a_file_that_exists', i, 1), err);
|
|
common.expectsError(() => fs.lchownSync('not_a_file_that_exists', 1, i), err);
|
|
|
|
promises.lchown('not_a_file_that_exists', i, 1)
|
|
.then(common.mustNotCall())
|
|
.catch(common.expectsError(err));
|
|
|
|
promises.lchown('not_a_file_that_exists', 1, i)
|
|
.then(common.mustNotCall())
|
|
.catch(common.expectsError(err));
|
|
});
|
|
|
|
// Validate the callback argument.
|
|
[false, 1, 'test', {}, [], null, undefined].forEach((i) => {
|
|
common.expectsError(() => fs.lchown('not_a_file_that_exists', 1, 1, i), {
|
|
type: TypeError,
|
|
code: 'ERR_INVALID_CALLBACK'
|
|
});
|
|
});
|
|
|
|
if (!common.isWindows) {
|
|
const testFile = path.join(tmpdir.path, path.basename(__filename));
|
|
const uid = process.geteuid();
|
|
const gid = process.getegid();
|
|
|
|
tmpdir.refresh();
|
|
fs.copyFileSync(__filename, testFile);
|
|
fs.lchownSync(testFile, uid, gid);
|
|
fs.lchown(testFile, uid, gid, common.mustCall(async (err) => {
|
|
assert.ifError(err);
|
|
await promises.lchown(testFile, uid, gid);
|
|
}));
|
|
}
|