mirror of
https://github.com/nodejs/node.git
synced 2025-05-07 15:35:41 +00:00
c072a80717
This commit updates the JS layer's validation of file descriptors to check for int32s >= 0 instead of uint32s. PR-URL: https://github.com/nodejs/node/pull/28984 Fixes: https://github.com/nodejs/node/issues/28980 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
64 lines
1.8 KiB
JavaScript
64 lines
1.8 KiB
JavaScript
'use strict';
|
|
|
|
require('../common');
|
|
const assert = require('assert');
|
|
const fs = require('fs');
|
|
|
|
function testFd(input, errObj) {
|
|
assert.throws(() => fs.fchown(input), errObj);
|
|
assert.throws(() => fs.fchownSync(input), errObj);
|
|
}
|
|
|
|
function testUid(input, errObj) {
|
|
assert.throws(() => fs.fchown(1, input), errObj);
|
|
assert.throws(() => fs.fchownSync(1, input), errObj);
|
|
}
|
|
|
|
function testGid(input, errObj) {
|
|
assert.throws(() => fs.fchown(1, 1, input), errObj);
|
|
assert.throws(() => fs.fchownSync(1, 1, input), errObj);
|
|
}
|
|
|
|
['', false, null, undefined, {}, []].forEach((input) => {
|
|
const errObj = {
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
name: 'TypeError',
|
|
message: 'The "fd" argument must be of type number. Received type ' +
|
|
typeof input
|
|
};
|
|
testFd(input, errObj);
|
|
errObj.message = errObj.message.replace('fd', 'uid');
|
|
testUid(input, errObj);
|
|
errObj.message = errObj.message.replace('uid', 'gid');
|
|
testGid(input, errObj);
|
|
});
|
|
|
|
[Infinity, NaN].forEach((input) => {
|
|
const errObj = {
|
|
code: 'ERR_OUT_OF_RANGE',
|
|
name: 'RangeError',
|
|
message: 'The value of "fd" is out of range. It must be an integer. ' +
|
|
`Received ${input}`
|
|
};
|
|
testFd(input, errObj);
|
|
errObj.message = errObj.message.replace('fd', 'uid');
|
|
testUid(input, errObj);
|
|
errObj.message = errObj.message.replace('uid', 'gid');
|
|
testGid(input, errObj);
|
|
});
|
|
|
|
[-1, 2 ** 32].forEach((input) => {
|
|
const errObj = {
|
|
code: 'ERR_OUT_OF_RANGE',
|
|
name: 'RangeError',
|
|
message: 'The value of "fd" is out of range. It must be ' +
|
|
`>= 0 && <= 2147483647. Received ${input}`
|
|
};
|
|
testFd(input, errObj);
|
|
errObj.message = 'The value of "uid" is out of range. It must be >= 0 && ' +
|
|
`< 4294967296. Received ${input}`;
|
|
testUid(input, errObj);
|
|
errObj.message = errObj.message.replace('uid', 'gid');
|
|
testGid(input, errObj);
|
|
});
|