mirror of
https://github.com/nodejs/node.git
synced 2025-05-07 17:32:22 +00:00
274364580a
Currently, if this test is run as the root user the following
failure will occur:
=== release test-fs-copyfile-respect-permissions ===
Path: parallel/test-fs-copyfile-respect-permissions
assert.js:89
throw new AssertionError(obj);
^
AssertionError [ERR_ASSERTION]: Missing expected exception (check).
at Object.<anonymous>
(/node/test/parallel/test-fs-copyfile-respect-permissions.js:38:10)
at Module._compile (internal/modules/cjs/loader.js:759:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:770:10)
at Module.load (internal/modules/cjs/loader.js:628:32)
at Function.Module._load (internal/modules/cjs/loader.js:555:12)
at Function.Module.runMain (internal/modules/cjs/loader.js:826:10)
at internal/main/run_main_module.js:17:11
Command:
out/Release/node test/parallel/test-fs-copyfile-respect-permissions.js
[05:41|% 100|+ 2620|- 1]: Done
This commit adds a root user check and skips this test if running as the
user root.
PR-URL: https://github.com/nodejs/node/pull/27378
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
57 lines
1.3 KiB
JavaScript
57 lines
1.3 KiB
JavaScript
'use strict';
|
|
|
|
// Test that fs.copyFile() respects file permissions.
|
|
// Ref: https://github.com/nodejs/node/issues/26936
|
|
|
|
const common = require('../common');
|
|
|
|
if (!common.isWindows && process.getuid() === 0)
|
|
common.skip('as this test should not be run as `root`');
|
|
|
|
const tmpdir = require('../common/tmpdir');
|
|
tmpdir.refresh();
|
|
|
|
const assert = require('assert');
|
|
const fs = require('fs');
|
|
const path = require('path');
|
|
|
|
let n = 0;
|
|
|
|
function beforeEach() {
|
|
n++;
|
|
const source = path.join(tmpdir.path, `source${n}`);
|
|
const dest = path.join(tmpdir.path, `dest${n}`);
|
|
fs.writeFileSync(source, 'source');
|
|
fs.writeFileSync(dest, 'dest');
|
|
fs.chmodSync(dest, '444');
|
|
|
|
const check = (err) => {
|
|
const expected = ['EACCES', 'EPERM'];
|
|
assert(expected.includes(err.code), `${err.code} not in ${expected}`);
|
|
assert.strictEqual(fs.readFileSync(dest, 'utf8'), 'dest');
|
|
return true;
|
|
};
|
|
|
|
return { source, dest, check };
|
|
}
|
|
|
|
// Test synchronous API.
|
|
{
|
|
const { source, dest, check } = beforeEach();
|
|
assert.throws(() => { fs.copyFileSync(source, dest); }, check);
|
|
}
|
|
|
|
// Test promises API.
|
|
{
|
|
const { source, dest, check } = beforeEach();
|
|
(async () => {
|
|
await assert.rejects(fs.promises.copyFile(source, dest), check);
|
|
})();
|
|
}
|
|
|
|
// Test callback API.
|
|
{
|
|
const { source, dest, check } = beforeEach();
|
|
fs.copyFile(source, dest, common.mustCall(check));
|
|
}
|