mirror of
https://github.com/nodejs/node.git
synced 2025-05-07 15:35:41 +00:00
f17f467544
Currently, configuring --without-ssl will cause the lint-js target to
fail with the following error:
$ make lint-js
Running JS linter...
internal/util.js:101
throw new ERR_NO_CRYPTO();
^
Error [ERR_NO_CRYPTO]:
Node.js is not compiled with OpenSSL crypto support
at assertCrypto (internal/util.js:101:11)
at crypto.js:31:1
...
(/node/tools/node_modules/eslint/node_modules/file-entry-cache/
cache.js:2:14)
at Module._compile (internal/modules/cjs/loader.js:746:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:757:10)
make: *** [lint-js] Error 1
There are also a number of tests that are affected in a similar way.
This commit adds crypto checks to allow for lint-js and the affected
tests to be skipped when configured --without-ssl.
PR-URL: https://github.com/nodejs/node/pull/26182
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
36 lines
964 B
JavaScript
36 lines
964 B
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
if (!common.hasCrypto)
|
|
common.skip('missing crypto');
|
|
|
|
common.skipIfEslintMissing();
|
|
|
|
const RuleTester = require('../../tools/node_modules/eslint').RuleTester;
|
|
const rule = require('../../tools/eslint-rules/prefer-assert-iferror');
|
|
|
|
new RuleTester().run('prefer-assert-iferror', rule, {
|
|
valid: [
|
|
'assert.ifError(err);',
|
|
'if (err) throw somethingElse;',
|
|
'throw err;',
|
|
'if (err) { throw somethingElse; }'
|
|
],
|
|
invalid: [
|
|
{
|
|
code: 'require("assert");\n' +
|
|
'if (err) throw err;',
|
|
errors: [{ message: 'Use assert.ifError(err) instead.' }],
|
|
output: 'require("assert");\n' +
|
|
'assert.ifError(err);'
|
|
},
|
|
{
|
|
code: 'require("assert");\n' +
|
|
'if (error) { throw error; }',
|
|
errors: [{ message: 'Use assert.ifError(error) instead.' }],
|
|
output: 'require("assert");\n' +
|
|
'assert.ifError(error);'
|
|
}
|
|
]
|
|
});
|