mirror of
https://github.com/nodejs/node.git
synced 2025-05-07 13:47:16 +00:00
c6b6c92185
This makes a effort to make sure all of these errors will actually also show the received input. On top of that it refactors a few tests for better maintainability. It will also change the returned type to always be a simple typeof instead of special handling null. PR-URL: https://github.com/nodejs/node/pull/19445 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
48 lines
1.2 KiB
JavaScript
48 lines
1.2 KiB
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
const dgram = require('dgram');
|
|
const dns = require('dns');
|
|
|
|
{
|
|
// Verify that the provided lookup function is called.
|
|
const lookup = common.mustCall((host, family, callback) => {
|
|
dns.lookup(host, family, callback);
|
|
});
|
|
|
|
const socket = dgram.createSocket({ type: 'udp4', lookup });
|
|
|
|
socket.bind(common.mustCall(() => {
|
|
socket.close();
|
|
}));
|
|
}
|
|
|
|
{
|
|
// Verify that lookup defaults to dns.lookup().
|
|
const originalLookup = dns.lookup;
|
|
|
|
dns.lookup = common.mustCall((host, family, callback) => {
|
|
dns.lookup = originalLookup;
|
|
originalLookup(host, family, callback);
|
|
});
|
|
|
|
const socket = dgram.createSocket({ type: 'udp4' });
|
|
|
|
socket.bind(common.mustCall(() => {
|
|
socket.close();
|
|
}));
|
|
}
|
|
|
|
{
|
|
// Verify that non-functions throw.
|
|
[null, true, false, 0, 1, NaN, '', 'foo', {}, Symbol()].forEach((value) => {
|
|
common.expectsError(() => {
|
|
dgram.createSocket({ type: 'udp4', lookup: value });
|
|
}, {
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
type: TypeError,
|
|
message: 'The "lookup" argument must be of type Function. ' +
|
|
`Received type ${typeof value}`
|
|
});
|
|
});
|
|
}
|