mirror of
https://github.com/nodejs/node.git
synced 2025-05-07 15:35:41 +00:00
399ef4f536
common.isOSXMojave was added because it was believed that there was a bug in macOS Mojave that allowed unprivileged users to bind to privileged ports. As it turns out, that was a feature not a bug. It is likely to be in all future versions of macOS. Remove isOSXMojave and skip appropriate tests based on isOSX. Refs: https://news.ycombinator.com/item?id=18302380 PR-URL: https://github.com/nodejs/node/pull/25658 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
53 lines
2.0 KiB
JavaScript
53 lines
2.0 KiB
JavaScript
// Copyright Joyent, Inc. and other Node contributors.
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a
|
|
// copy of this software and associated documentation files (the
|
|
// "Software"), to deal in the Software without restriction, including
|
|
// without limitation the rights to use, copy, modify, merge, publish,
|
|
// distribute, sublicense, and/or sell copies of the Software, and to permit
|
|
// persons to whom the Software is furnished to do so, subject to the
|
|
// following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included
|
|
// in all copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
|
|
// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
|
|
// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN
|
|
// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
|
|
// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
|
|
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
|
|
// USE OR OTHER DEALINGS IN THE SOFTWARE.
|
|
|
|
'use strict';
|
|
const common = require('../common');
|
|
|
|
// Skip on OS X Mojave. https://github.com/nodejs/node/issues/21679
|
|
if (common.isOSX)
|
|
common.skip('macOS may allow ordinary processes to use any port');
|
|
|
|
if (common.isWindows)
|
|
common.skip('not reliable on Windows');
|
|
|
|
if (process.getuid() === 0)
|
|
common.skip('as this test should not be run as `root`');
|
|
|
|
const assert = require('assert');
|
|
const cluster = require('cluster');
|
|
const net = require('net');
|
|
|
|
if (cluster.isMaster) {
|
|
// Master opens and binds the socket and shares it with the worker.
|
|
cluster.schedulingPolicy = cluster.SCHED_NONE;
|
|
cluster.fork().on('exit', common.mustCall(function(exitCode) {
|
|
assert.strictEqual(exitCode, 0);
|
|
}));
|
|
} else {
|
|
const s = net.createServer(common.mustNotCall());
|
|
s.listen(42, common.mustNotCall('listen should have failed'));
|
|
s.on('error', common.mustCall(function(err) {
|
|
assert.strictEqual(err.code, 'EACCES');
|
|
process.disconnect();
|
|
}));
|
|
}
|