mirror of
https://github.com/nodejs/node.git
synced 2025-05-07 12:03:30 +00:00
8007134189
Improve asserts to distinguish between reequest and response parsers. Change the assert sequence to first assert on the number of ids to easier identify if some operation is missing/incomplete. Destroy HTTP agent once expected number of events have been seen to avoid waiting on socket timeouts. Refs: https://github.com/nodejs/node/issues/28112 PR-URL: https://github.com/nodejs/node/pull/28253 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
90 lines
2.4 KiB
JavaScript
90 lines
2.4 KiB
JavaScript
'use strict';
|
|
require('../common');
|
|
const assert = require('assert');
|
|
const async_hooks = require('async_hooks');
|
|
const http = require('http');
|
|
|
|
// Regression test for https://github.com/nodejs/node/issues/19859.
|
|
// Checks that matching destroys are emitted when creating new/reusing old http
|
|
// parser instances.
|
|
|
|
const N = 50;
|
|
const KEEP_ALIVE = 100;
|
|
|
|
const createdIdsIncomingMessage = [];
|
|
const createdIdsClientRequest = [];
|
|
const destroyedIdsIncomingMessage = [];
|
|
const destroyedIdsClientRequest = [];
|
|
|
|
async_hooks.createHook({
|
|
init: (asyncId, type) => {
|
|
if (type === 'HTTPINCOMINGMESSAGE') {
|
|
createdIdsIncomingMessage.push(asyncId);
|
|
}
|
|
if (type === 'HTTPCLIENTREQUEST') {
|
|
createdIdsClientRequest.push(asyncId);
|
|
}
|
|
},
|
|
destroy: (asyncId) => {
|
|
if (createdIdsIncomingMessage.includes(asyncId)) {
|
|
destroyedIdsIncomingMessage.push(asyncId);
|
|
}
|
|
if (createdIdsClientRequest.includes(asyncId)) {
|
|
destroyedIdsClientRequest.push(asyncId);
|
|
}
|
|
|
|
if (destroyedIdsClientRequest.length === N && keepAliveAgent) {
|
|
keepAliveAgent.destroy();
|
|
keepAliveAgent = undefined;
|
|
}
|
|
|
|
if (destroyedIdsIncomingMessage.length === N && server.listening) {
|
|
server.close();
|
|
}
|
|
}
|
|
}).enable();
|
|
|
|
const server = http.createServer((req, res) => {
|
|
res.end('Hello');
|
|
});
|
|
|
|
let keepAliveAgent = new http.Agent({
|
|
keepAlive: true,
|
|
keepAliveMsecs: KEEP_ALIVE,
|
|
});
|
|
|
|
server.listen(0, () => {
|
|
for (let i = 0; i < N; ++i) {
|
|
(function makeRequest() {
|
|
http.get({
|
|
port: server.address().port,
|
|
agent: keepAliveAgent
|
|
}, (res) => {
|
|
res.resume();
|
|
});
|
|
})();
|
|
}
|
|
});
|
|
|
|
function checkOnExit() {
|
|
assert.strictEqual(createdIdsIncomingMessage.length, N);
|
|
assert.strictEqual(createdIdsClientRequest.length, N);
|
|
assert.strictEqual(destroyedIdsIncomingMessage.length, N);
|
|
assert.strictEqual(destroyedIdsClientRequest.length, N);
|
|
|
|
assert.deepStrictEqual(destroyedIdsIncomingMessage.sort(),
|
|
createdIdsIncomingMessage.sort());
|
|
assert.deepStrictEqual(destroyedIdsClientRequest.sort(),
|
|
createdIdsClientRequest.sort());
|
|
}
|
|
|
|
process.on('SIGTERM', () => {
|
|
// Catching SIGTERM and calling `process.exit(1)` so that the `exit` event
|
|
// is triggered and the assertions are checked. This can be useful for
|
|
// troubleshooting this test if it times out.
|
|
process.exit(1);
|
|
});
|
|
|
|
// Ordinary exit.
|
|
process.on('exit', checkOnExit);
|