mirror of
https://github.com/nodejs/node.git
synced 2025-05-19 22:10:53 +00:00
87719d792b
This commit makes node load extra certificates at startup instead of first use. PR-URL: https://github.com/nodejs/node/pull/23354 Fixes: https://github.com/nodejs/node/issues/20434 Refs: https://github.com/nodejs/node/issues/20432 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
41 lines
1.3 KiB
JavaScript
41 lines
1.3 KiB
JavaScript
'use strict';
|
|
// Flags: --expose-internals
|
|
|
|
const common = require('../common');
|
|
|
|
if (!common.hasCrypto)
|
|
common.skip('missing crypto');
|
|
|
|
const assert = require('assert');
|
|
const tls = require('tls');
|
|
const fixtures = require('../common/fixtures');
|
|
const { internalBinding } = require('internal/test/binding');
|
|
const binding = internalBinding('crypto');
|
|
|
|
const { fork } = require('child_process');
|
|
|
|
// This test ensures that extra certificates are loaded at startup.
|
|
if (process.argv[2] !== 'child') {
|
|
if (process.env.CHILD_USE_EXTRA_CA_CERTS === 'yes') {
|
|
assert.strictEqual(binding.isExtraRootCertsFileLoaded(), true);
|
|
} else if (process.env.CHILD_USE_EXTRA_CA_CERTS === 'no') {
|
|
assert.strictEqual(binding.isExtraRootCertsFileLoaded(), false);
|
|
tls.createServer({});
|
|
assert.strictEqual(binding.isExtraRootCertsFileLoaded(), false);
|
|
}
|
|
} else {
|
|
const NODE_EXTRA_CA_CERTS = fixtures.path('keys', 'ca1-cert.pem');
|
|
const extendsEnv = (obj) => Object.assign({}, process.env, obj);
|
|
|
|
[
|
|
extendsEnv({ CHILD_USE_EXTRA_CA_CERTS: 'yes', NODE_EXTRA_CA_CERTS }),
|
|
extendsEnv({ CHILD_USE_EXTRA_CA_CERTS: 'no' }),
|
|
].forEach((processEnv) => {
|
|
fork(__filename, ['child'], { env: processEnv })
|
|
.on('exit', common.mustCall((status) => {
|
|
// client did not succeed in connecting
|
|
assert.strictEqual(status, 0);
|
|
}));
|
|
});
|
|
}
|