node/test/parallel/test-stream-writable-null.js
Ruben Bridgewater 644fdd60d4
test: minor refactoring
Add punctuation and comments about code that should not throw.
Also remove a obsolete test and refactor some tests.

PR-URL: https://github.com/nodejs/node/pull/18669
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
2018-02-16 16:54:07 +01:00

62 lines
1.2 KiB
JavaScript

'use strict';
const common = require('../common');
const assert = require('assert');
const stream = require('stream');
class MyWritable extends stream.Writable {
constructor(opt) {
super(opt);
}
_write(chunk, encoding, callback) {
assert.notStrictEqual(chunk, null);
callback();
}
}
common.expectsError(
() => {
const m = new MyWritable({ objectMode: true });
m.write(null, (err) => assert.ok(err));
},
{
code: 'ERR_STREAM_NULL_VALUES',
type: TypeError,
message: 'May not write null values to stream'
}
);
{ // Should not throw.
const m = new MyWritable({ objectMode: true }).on('error', assert);
m.write(null, assert);
}
common.expectsError(
() => {
const m = new MyWritable();
m.write(false, (err) => assert.ok(err));
},
{
code: 'ERR_INVALID_ARG_TYPE',
type: TypeError
}
);
{ // Should not throw.
const m = new MyWritable().on('error', assert);
m.write(false, assert);
}
{ // Should not throw.
const m = new MyWritable({ objectMode: true });
m.write(false, assert.ifError);
}
{ // Should not throw.
const m = new MyWritable({ objectMode: true }).on('error', (e) => {
assert.ifError(e || new Error('should not get here'));
});
m.write(false, assert.ifError);
}