mirror of
https://github.com/nodejs/node.git
synced 2025-05-19 20:06:58 +00:00
5e3f51648e
This improves error handling for streams in a few ways. 1. It ensures that no user defined methods (_read, _write, ...) are run after .destroy has been called. 2. It introduces an explicit error to tell the user if they are write to write, etc to the stream after it has been destroyed. 3. It makes streams always emit close as the last thing after they have been destroyed 4. Changes the default _destroy to not gracefully end streams. It also updates net, http2, zlib and fs to the new error handling. PR-URL: https://github.com/nodejs/node/pull/18438 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net>
144 lines
3.2 KiB
JavaScript
144 lines
3.2 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
const { Transform } = require('stream');
|
|
const assert = require('assert');
|
|
|
|
{
|
|
const transform = new Transform({
|
|
transform(chunk, enc, cb) {}
|
|
});
|
|
|
|
transform.resume();
|
|
|
|
transform.on('end', common.mustNotCall());
|
|
transform.on('close', common.mustCall());
|
|
transform.on('finish', common.mustNotCall());
|
|
|
|
transform.destroy();
|
|
}
|
|
|
|
{
|
|
const transform = new Transform({
|
|
transform(chunk, enc, cb) {}
|
|
});
|
|
transform.resume();
|
|
|
|
const expected = new Error('kaboom');
|
|
|
|
transform.on('end', common.mustNotCall());
|
|
transform.on('finish', common.mustNotCall());
|
|
transform.on('close', common.mustCall());
|
|
transform.on('error', common.mustCall((err) => {
|
|
assert.strictEqual(err, expected);
|
|
}));
|
|
|
|
transform.destroy(expected);
|
|
}
|
|
|
|
{
|
|
const transform = new Transform({
|
|
transform(chunk, enc, cb) {}
|
|
});
|
|
|
|
transform._destroy = common.mustCall(function(err, cb) {
|
|
assert.strictEqual(err, expected);
|
|
cb(err);
|
|
}, 1);
|
|
|
|
const expected = new Error('kaboom');
|
|
|
|
transform.on('finish', common.mustNotCall('no finish event'));
|
|
transform.on('close', common.mustCall());
|
|
transform.on('error', common.mustCall((err) => {
|
|
assert.strictEqual(err, expected);
|
|
}));
|
|
|
|
transform.destroy(expected);
|
|
}
|
|
|
|
{
|
|
const expected = new Error('kaboom');
|
|
const transform = new Transform({
|
|
transform(chunk, enc, cb) {},
|
|
destroy: common.mustCall(function(err, cb) {
|
|
assert.strictEqual(err, expected);
|
|
cb();
|
|
}, 1)
|
|
});
|
|
transform.resume();
|
|
|
|
transform.on('end', common.mustNotCall('no end event'));
|
|
transform.on('close', common.mustCall());
|
|
transform.on('finish', common.mustNotCall('no finish event'));
|
|
|
|
// error is swallowed by the custom _destroy
|
|
transform.on('error', common.mustNotCall('no error event'));
|
|
|
|
transform.destroy(expected);
|
|
}
|
|
|
|
{
|
|
const transform = new Transform({
|
|
transform(chunk, enc, cb) {}
|
|
});
|
|
|
|
transform._destroy = common.mustCall(function(err, cb) {
|
|
assert.strictEqual(err, null);
|
|
cb();
|
|
}, 1);
|
|
|
|
transform.destroy();
|
|
}
|
|
|
|
{
|
|
const transform = new Transform({
|
|
transform(chunk, enc, cb) {}
|
|
});
|
|
transform.resume();
|
|
|
|
transform._destroy = common.mustCall(function(err, cb) {
|
|
assert.strictEqual(err, null);
|
|
process.nextTick(() => {
|
|
this.push(null);
|
|
this.end();
|
|
cb();
|
|
});
|
|
}, 1);
|
|
|
|
const fail = common.mustNotCall('no event');
|
|
|
|
transform.on('finish', fail);
|
|
transform.on('end', fail);
|
|
transform.on('close', common.mustCall());
|
|
|
|
transform.destroy();
|
|
|
|
transform.removeListener('end', fail);
|
|
transform.removeListener('finish', fail);
|
|
transform.on('end', common.mustCall());
|
|
transform.on('finish', common.mustCall());
|
|
}
|
|
|
|
{
|
|
const transform = new Transform({
|
|
transform(chunk, enc, cb) {}
|
|
});
|
|
|
|
const expected = new Error('kaboom');
|
|
|
|
transform._destroy = common.mustCall(function(err, cb) {
|
|
assert.strictEqual(err, null);
|
|
cb(expected);
|
|
}, 1);
|
|
|
|
transform.on('close', common.mustCall());
|
|
transform.on('finish', common.mustNotCall('no finish event'));
|
|
transform.on('end', common.mustNotCall('no end event'));
|
|
transform.on('error', common.mustCall((err) => {
|
|
assert.strictEqual(err, expected);
|
|
}));
|
|
|
|
transform.destroy();
|
|
}
|