node/test/parallel/test-stream-readable-no-unneeded-readable.js
陈刚 86c659ba61 stream: add a test case for the underlying cause.
The original test case hides the underlying cause by using
`PassThrough`. This change adds a test case for the underlying cause.
This makes it clearer and easier to be understood.

Refs: https://github.com/nodejs/node/pull/18372

PR-URL: https://github.com/nodejs/node/pull/18575
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
2018-02-08 16:31:47 +01:00

63 lines
1.1 KiB
JavaScript

'use strict';
const common = require('../common');
const { Readable, PassThrough } = require('stream');
function test(r) {
const wrapper = new Readable({
read: () => {
let data = r.read();
if (data) {
wrapper.push(data);
return;
}
r.once('readable', function() {
data = r.read();
if (data) {
wrapper.push(data);
}
// else the end event should fire
});
},
});
r.once('end', function() {
wrapper.push(null);
});
wrapper.resume();
wrapper.once('end', common.mustCall());
}
{
const source = new Readable({
read: () => {}
});
source.push('foo');
source.push('bar');
source.push(null);
const pt = source.pipe(new PassThrough());
test(pt);
}
{
// This is the underlying cause of the above test case.
const pushChunks = ['foo', 'bar'];
const r = new Readable({
read: () => {
const chunk = pushChunks.shift();
if (chunk) {
// synchronous call
r.push(chunk);
} else {
// asynchronous call
process.nextTick(() => r.push(null));
}
},
});
test(r);
}