mirror of
https://github.com/nodejs/node.git
synced 2025-05-19 20:06:58 +00:00
12b9ec09b0
Requiring `respondWithFile()` to only work with regular files is an artificial restriction on Node’s side and has become unnecessary. Offsets or lengths cannot be specified for those files, but that is an inherent property of other file types. PR-URL: https://github.com/nodejs/node/pull/18936 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
62 lines
1.6 KiB
JavaScript
62 lines
1.6 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
if (!common.hasCrypto)
|
|
common.skip('missing crypto');
|
|
if (common.isWindows)
|
|
common.skip('no mkfifo on Windows');
|
|
const child_process = require('child_process');
|
|
const path = require('path');
|
|
const fs = require('fs');
|
|
const http2 = require('http2');
|
|
const assert = require('assert');
|
|
|
|
const tmpdir = require('../common/tmpdir');
|
|
tmpdir.refresh();
|
|
|
|
const pipeName = path.join(tmpdir.path, 'pipe');
|
|
|
|
const mkfifo = child_process.spawnSync('mkfifo', [ pipeName ]);
|
|
if (mkfifo.error && mkfifo.error.code === 'ENOENT') {
|
|
common.skip('missing mkfifo');
|
|
}
|
|
|
|
process.on('exit', () => fs.unlinkSync(pipeName));
|
|
|
|
const server = http2.createServer();
|
|
server.on('stream', (stream) => {
|
|
stream.respondWithFile(pipeName, {
|
|
'content-type': 'text/plain'
|
|
}, {
|
|
offset: 10,
|
|
onError(err) {
|
|
common.expectsError({
|
|
code: 'ERR_HTTP2_SEND_FILE_NOSEEK',
|
|
type: Error,
|
|
message: 'Offset or length can only be specified for regular files'
|
|
})(err);
|
|
|
|
stream.respond({ ':status': 404 });
|
|
stream.end();
|
|
},
|
|
statCheck: common.mustNotCall()
|
|
});
|
|
});
|
|
server.listen(0, () => {
|
|
|
|
const client = http2.connect(`http://localhost:${server.address().port}`);
|
|
const req = client.request();
|
|
|
|
req.on('response', common.mustCall((headers) => {
|
|
assert.strictEqual(headers[':status'], 404);
|
|
}));
|
|
req.on('data', common.mustNotCall());
|
|
req.on('end', common.mustCall(() => {
|
|
client.close();
|
|
server.close();
|
|
}));
|
|
req.end();
|
|
});
|
|
|
|
fs.writeFile(pipeName, 'Hello, world!\n', common.mustCall());
|