mirror of
https://github.com/nodejs/node.git
synced 2025-05-20 06:40:22 +00:00
b55a11d1b1
When a request with a long payload is received, http2 does not allow a response that does not process all the incoming payload. Add a conditional Http2Stream.close call that runs only if the user hasn't attempted to read the stream. PR-URL: https://github.com/nodejs/node/pull/20084 Fixes: https://github.com/nodejs/node/issues/20060 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
103 lines
3.1 KiB
JavaScript
103 lines
3.1 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
if (!common.hasCrypto)
|
|
common.skip('missing crypto');
|
|
const assert = require('assert');
|
|
const h2 = require('http2');
|
|
|
|
const { PerformanceObserver } = require('perf_hooks');
|
|
|
|
const obs = new PerformanceObserver(common.mustCall((items) => {
|
|
const entry = items.getEntries()[0];
|
|
assert.strictEqual(entry.entryType, 'http2');
|
|
assert.strictEqual(typeof entry.startTime, 'number');
|
|
assert.strictEqual(typeof entry.duration, 'number');
|
|
switch (entry.name) {
|
|
case 'Http2Session':
|
|
assert.strictEqual(typeof entry.pingRTT, 'number');
|
|
assert.strictEqual(typeof entry.streamAverageDuration, 'number');
|
|
assert.strictEqual(typeof entry.streamCount, 'number');
|
|
assert.strictEqual(typeof entry.framesReceived, 'number');
|
|
assert.strictEqual(typeof entry.framesSent, 'number');
|
|
assert.strictEqual(typeof entry.bytesWritten, 'number');
|
|
assert.strictEqual(typeof entry.bytesRead, 'number');
|
|
assert.strictEqual(typeof entry.maxConcurrentStreams, 'number');
|
|
switch (entry.type) {
|
|
case 'server':
|
|
assert.strictEqual(entry.streamCount, 1);
|
|
assert(entry.framesReceived >= 3);
|
|
break;
|
|
case 'client':
|
|
assert.strictEqual(entry.streamCount, 1);
|
|
assert.strictEqual(entry.framesReceived, 8);
|
|
break;
|
|
default:
|
|
assert.fail('invalid Http2Session type');
|
|
}
|
|
break;
|
|
case 'Http2Stream':
|
|
assert.strictEqual(typeof entry.timeToFirstByte, 'number');
|
|
assert.strictEqual(typeof entry.timeToFirstByteSent, 'number');
|
|
assert.strictEqual(typeof entry.timeToFirstHeader, 'number');
|
|
assert.strictEqual(typeof entry.bytesWritten, 'number');
|
|
assert.strictEqual(typeof entry.bytesRead, 'number');
|
|
break;
|
|
default:
|
|
assert.fail('invalid entry name');
|
|
}
|
|
}, 4));
|
|
obs.observe({ entryTypes: ['http2'] });
|
|
|
|
const body =
|
|
'<html><head></head><body><h1>this is some data</h2></body></html>';
|
|
|
|
const server = h2.createServer();
|
|
|
|
// we use the lower-level API here
|
|
server.on('stream', common.mustCall(onStream));
|
|
|
|
function onStream(stream, headers, flags) {
|
|
assert.strictEqual(headers[':scheme'], 'http');
|
|
assert.ok(headers[':authority']);
|
|
assert.strictEqual(headers[':method'], 'GET');
|
|
assert.strictEqual(flags, 5);
|
|
stream.respond({
|
|
'content-type': 'text/html',
|
|
':status': 200
|
|
});
|
|
stream.write(body.slice(0, 20));
|
|
stream.end(body.slice(20));
|
|
}
|
|
|
|
server.on('session', common.mustCall((session) => {
|
|
session.ping(common.mustCall());
|
|
}));
|
|
|
|
server.listen(0);
|
|
|
|
server.on('listening', common.mustCall(() => {
|
|
|
|
const client = h2.connect(`http://localhost:${server.address().port}`);
|
|
|
|
client.on('connect', common.mustCall(() => {
|
|
client.ping(common.mustCall());
|
|
}));
|
|
|
|
const req = client.request();
|
|
|
|
req.on('response', common.mustCall());
|
|
|
|
let data = '';
|
|
req.setEncoding('utf8');
|
|
req.on('data', (d) => data += d);
|
|
req.on('end', common.mustCall(() => {
|
|
assert.strictEqual(body, data);
|
|
}));
|
|
req.on('close', common.mustCall(() => {
|
|
client.close();
|
|
server.close();
|
|
}));
|
|
|
|
}));
|