mirror of
https://github.com/nodejs/node.git
synced 2025-05-19 20:06:58 +00:00
9b7a6914a7
Currently the writable side of the socket is closed as soon as `UV_EOF` is read regardless of the state of the socket. This allows the handle to be closed before `'end'` is emitted and thus `'close'` can be emitted before `'end'` if the socket is paused. This commit prevents the handle from being closed until `'end'` is emitted ensuring the correct order of events. PR-URL: https://github.com/nodejs/node/pull/19241 Fixes: https://github.com/nodejs/node/issues/19166 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
71 lines
2.2 KiB
JavaScript
71 lines
2.2 KiB
JavaScript
'use strict';
|
|
// Flags: --expose-internals
|
|
|
|
const common = require('../common');
|
|
|
|
if (!common.hasCrypto)
|
|
common.skip('missing crypto');
|
|
|
|
const h2 = require('http2');
|
|
const net = require('net');
|
|
const { NghttpError } = require('internal/http2/util');
|
|
const h2test = require('../common/http2');
|
|
let client;
|
|
|
|
const server = h2.createServer();
|
|
server.on('stream', common.mustCall((stream) => {
|
|
stream.respond();
|
|
stream.end('ok');
|
|
|
|
// the error will be emitted asynchronously
|
|
stream.on('error', common.expectsError({
|
|
type: NghttpError,
|
|
code: 'ERR_HTTP2_ERROR',
|
|
message: 'Stream was already closed or invalid'
|
|
}));
|
|
}, 2));
|
|
|
|
server.on('session', common.mustCall((session) => {
|
|
session.on('error', common.expectsError({
|
|
code: 'ERR_HTTP2_ERROR',
|
|
type: NghttpError,
|
|
message: 'Stream was already closed or invalid'
|
|
}));
|
|
}));
|
|
|
|
const settings = new h2test.SettingsFrame();
|
|
const settingsAck = new h2test.SettingsFrame(true);
|
|
const head1 = new h2test.HeadersFrame(1, h2test.kFakeRequestHeaders, 0, true);
|
|
const head2 = new h2test.HeadersFrame(3, h2test.kFakeRequestHeaders, 0, true);
|
|
const head3 = new h2test.HeadersFrame(1, h2test.kFakeRequestHeaders, 0, true);
|
|
const head4 = new h2test.HeadersFrame(5, h2test.kFakeRequestHeaders, 0, true);
|
|
|
|
server.listen(0, () => {
|
|
client = net.connect(server.address().port, () => {
|
|
client.write(h2test.kClientMagic, () => {
|
|
client.write(settings.data, () => {
|
|
client.write(settingsAck.data);
|
|
// This will make it ok.
|
|
client.write(head1.data, () => {
|
|
// This will make it ok.
|
|
client.write(head2.data, () => {
|
|
// This will cause an error to occur because the client is
|
|
// attempting to reuse an already closed stream. This must
|
|
// cause the server session to be torn down.
|
|
client.write(head3.data, () => {
|
|
// This won't ever make it to the server
|
|
client.write(head4.data);
|
|
});
|
|
});
|
|
});
|
|
});
|
|
});
|
|
});
|
|
|
|
// An error may or may not be emitted on the client side, we don't care
|
|
// either way if it is, but we don't want to die if it is.
|
|
client.on('error', () => {});
|
|
client.on('close', common.mustCall(() => server.close()));
|
|
client.resume();
|
|
});
|